From: Liviu Dudau <liviu.dudau@arm.com>
To: Christian Hewitt <christianshewitt@gmail.com>
Cc: Boris Brezillon <boris.brezillon@collabora.com>,
Steven Price <steven.price@arm.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/panthor: correct firmware related messages
Date: Tue, 24 Mar 2026 16:06:36 +0000 [thread overview]
Message-ID: <acK2jA36UhlEIKkM@e142607> (raw)
In-Reply-To: <20260323081132.3217646-1-christianshewitt@gmail.com>
On Mon, Mar 23, 2026 at 08:11:32AM +0000, Christian Hewitt wrote:
> Some English language corrections to firmware messages. No
> functional changes.
>
> Signed-off-by: Christian Hewitt <christianshewitt@gmail.com>
Pushed to drm-misc-next.
Best regards,
Liviu
> ---
> drivers/gpu/drm/panthor/panthor_fw.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_fw.c b/drivers/gpu/drm/panthor/panthor_fw.c
> index a64ec8756bed..349bb6b0e7bf 100644
> --- a/drivers/gpu/drm/panthor/panthor_fw.c
> +++ b/drivers/gpu/drm/panthor/panthor_fw.c
> @@ -580,7 +580,7 @@ static int panthor_fw_load_section_entry(struct panthor_device *ptdev,
>
> if (hdr.flags & CSF_FW_BINARY_IFACE_ENTRY_PROT) {
> drm_warn(&ptdev->base,
> - "Firmware protected mode entry not be supported, ignoring");
> + "Firmware protected mode entry is not supported, ignoring");
> return 0;
> }
>
> @@ -749,7 +749,7 @@ static int panthor_fw_load_entry(struct panthor_device *ptdev,
>
> if ((iter->offset % sizeof(u32)) ||
> (CSF_FW_BINARY_ENTRY_SIZE(ehdr) % sizeof(u32))) {
> - drm_err(&ptdev->base, "Firmware entry isn't 32 bit aligned, offset=0x%x size=0x%x\n",
> + drm_err(&ptdev->base, "Firmware entry is not 32-bit aligned, offset=0x%x size=0x%x\n",
> (u32)(iter->offset - sizeof(u32)), CSF_FW_BINARY_ENTRY_SIZE(ehdr));
> return -EINVAL;
> }
> --
> 2.43.0
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
next prev parent reply other threads:[~2026-03-24 16:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-23 8:11 [PATCH] drm/panthor: correct firmware related messages Christian Hewitt
2026-03-23 8:22 ` Boris Brezillon
2026-03-23 11:18 ` Liviu Dudau
2026-03-24 16:06 ` Liviu Dudau [this message]
2026-03-24 22:01 ` Claude review: " Claude Code Review Bot
2026-03-24 22:01 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acK2jA36UhlEIKkM@e142607 \
--to=liviu.dudau@arm.com \
--cc=airlied@gmail.com \
--cc=boris.brezillon@collabora.com \
--cc=christianshewitt@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=steven.price@arm.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox