From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D27D8CD5BB6 for ; Fri, 22 May 2026 19:13:06 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B8ECE10E587; Fri, 22 May 2026 19:13:03 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="XStWa2fS"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id 06DC510E29E; Fri, 22 May 2026 19:13:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1779477182; x=1811013182; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=3IfPthyDl2oPPglM9oqDGvx1An2T/XqIOjxgRfcIt3I=; b=XStWa2fSiD2GaDPewKipBAzs2t3sL0AZCctpg4/MpdPfOrnPEzHuM+E1 7XsDnHWLCP12lC/y1spOF8WI/7JsoYfccI1Wyb861lvzqW2SKq500rYtV Yos3gNfjuPj+fYu1swFrurHoMQG9gpveRZrULMDNCo4yVaf1yAdURL8x6 N8+2jj2yEKgWNBeLVUDq0WJV6SuH4nJWYSklvJbVcyhwZgtcC3q/1CBpg PkZb8rCIc8xjlZMpzO8cTw56CO4XHCW6QeP00qCKy84WJ4ffN1HtjVsdE PdwJhtthZcLTHg+Ee8TclX3RkJ/UheFy/e623Z/0l0ZpPkKp25hla1iRn Q==; X-CSE-ConnectionGUID: owG9jCzETHSU6vr59o0JEw== X-CSE-MsgGUID: 1HDurxAURP+OsCHdJ5fvzQ== X-IronPort-AV: E=McAfee;i="6800,10657,11794"; a="91522279" X-IronPort-AV: E=Sophos;i="6.24,162,1774335600"; d="scan'208";a="91522279" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2026 12:13:00 -0700 X-CSE-ConnectionGUID: 7NpFBSNpQWaxr5HTnm4f4A== X-CSE-MsgGUID: J5AfsVnqQKOwWRpPLh2Bsg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,162,1774335600"; d="scan'208";a="245281652" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.245.71]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 May 2026 12:12:53 -0700 Date: Fri, 22 May 2026 22:12:47 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Nicolas Frattaroli Cc: Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?iso-8859-1?Q?K=F6nig?= , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sandy Huang , Heiko =?iso-8859-1?Q?St=FCbner?= , Andy Yan , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Dmitry Baryshkov , Sascha Hauer , Rob Herring , Jonathan Corbet , Shuah Khan , Daniel Stone , kernel@collabora.com, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-doc@vger.kernel.org, wayland-devel@lists.freedesktop.org Subject: Re: [PATCH v15 11/28] drm/i915/hdmi: Add YCBCR444 handling for sink formats Message-ID: References: <20260522-color-format-v15-0-21fb136c9df2@collabora.com> <20260522-color-format-v15-11-21fb136c9df2@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20260522-color-format-v15-11-21fb136c9df2@collabora.com> X-Patchwork-Hint: comment Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, May 22, 2026 at 02:32:02PM +0200, Nicolas Frattaroli wrote: > In anticipation of userspace being able to explicitly select supported > sink formats, add handling of the YCBCR444 sink format. The AUTO path > does not choose this format, but with explicit format selection added to > the driver, it becomes a possibility. >=20 > Check for YCBCR444 support on the sink in sink_bpc_possible, and on the > source and sink in sink_format_valid. >=20 > Acked-by: Daniel Stone > Signed-off-by: Nicolas Frattaroli > --- > drivers/gpu/drm/i915/display/intel_hdmi.c | 32 +++++++++++++++++++++++++= ++++++ > 1 file changed, 32 insertions(+) >=20 > diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/= i915/display/intel_hdmi.c > index 9076c2b176ec..97cb321e6568 100644 > --- a/drivers/gpu/drm/i915/display/intel_hdmi.c > +++ b/drivers/gpu/drm/i915/display/intel_hdmi.c > @@ -1966,6 +1966,8 @@ static bool intel_hdmi_sink_bpc_possible(struct drm= _connector *_connector, > =20 > if (sink_format =3D=3D INTEL_OUTPUT_FORMAT_YCBCR420) > return hdmi->y420_dc_modes & DRM_EDID_YCBCR420_DC_36; > + else if (sink_format =3D=3D INTEL_OUTPUT_FORMAT_YCBCR444) > + return info->edid_hdmi_ycbcr444_dc_modes & DRM_EDID_HDMI_DC_36; > else > return info->edid_hdmi_rgb444_dc_modes & DRM_EDID_HDMI_DC_36; > case 10: > @@ -1974,6 +1976,8 @@ static bool intel_hdmi_sink_bpc_possible(struct drm= _connector *_connector, > =20 > if (sink_format =3D=3D INTEL_OUTPUT_FORMAT_YCBCR420) > return hdmi->y420_dc_modes & DRM_EDID_YCBCR420_DC_30; > + else if (sink_format =3D=3D INTEL_OUTPUT_FORMAT_YCBCR444) > + return info->edid_hdmi_ycbcr444_dc_modes & DRM_EDID_HDMI_DC_30; > else > return info->edid_hdmi_rgb444_dc_modes & DRM_EDID_HDMI_DC_30; > case 8: > @@ -2021,6 +2025,27 @@ intel_hdmi_mode_clock_valid(struct drm_connector *= _connector, int clock, > return status; > } > =20 > +/** > + * intel_hdmi_can_ycbcr444 - Check whether connector can output YCbCr444 > + * @connector: pointer to &struct intel_connector to check > + * > + * Checks whether the hardware that backs @connector is capable of outpu= tting > + * YCbCr444 video over HDMI. Does not check whether currently connected = sink is > + * capable of receiving it. > + * > + * Returns: %true if source supports outputting YCbCr444, %false otherwi= se. > + */ We don't need kernel docs for internal stuff. > +static bool > +intel_hdmi_can_ycbcr444(struct intel_connector *connector) > +{ > + const struct intel_display *display =3D to_intel_display(connector); > + > + if (HAS_GMCH(display)) > + return true; Exactly the wrong way around. > + > + return false; > +} > + > static enum drm_mode_status > intel_hdmi_sink_format_valid(struct intel_connector *connector, > const struct drm_display_mode *mode, > @@ -2038,6 +2063,13 @@ intel_hdmi_sink_format_valid(struct intel_connecto= r *connector, > =20 > return MODE_OK; I would put the 444 stuff here between 420 and RGB. Then we logically go from YCbCr420 -> YCbCr444 -> RGB when reading the code. > case INTEL_OUTPUT_FORMAT_RGB: > + return MODE_OK; > + case INTEL_OUTPUT_FORMAT_YCBCR444: > + if (!intel_hdmi_can_ycbcr444(connector)) > + return MODE_BAD; We're missing the has_hdmi_sink check as well. > + if (!(info->color_formats & BIT(DRM_OUTPUT_COLOR_FORMAT_YCBCR444))) > + return MODE_BAD; > + > return MODE_OK; > default: > MISSING_CASE(sink_format); >=20 > --=20 > 2.54.0 --=20 Ville Syrj=E4l=E4 Intel