From: Helge Deller <deller@gmx.de>
To: Chen Ni <nichen@iscas.ac.cn>,
linux-fbdev@vger.kernel.org, linux-omap@vger.kernel.org
Cc: tglx@kernel.org, mingo@kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] video: fbdev: omapfb: Add missing error check for clk_get()
Date: Tue, 10 Mar 2026 18:42:30 +0100 [thread overview]
Message-ID: <b1418319-63d5-4f1a-91dd-ea2e0840663c@gmx.de> (raw)
In-Reply-To: <20260310085625.2648545-1-nichen@iscas.ac.cn>
On 3/10/26 09:56, Chen Ni wrote:
> The hwa742_init() function did not check the return value of clk_get().
> This could lead to dereferencing an error pointer in subsequent clock
> operations, potentially causing a kernel crash.
>
> Fix this by adding a missing error check and ensuring proper clock
> resource cleanup on failure and driver removal.
>
> Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
> ---
> drivers/video/fbdev/omap/hwa742.c | 4 ++++
> 1 file changed, 4 insertions(+)
applied.
Thanks!
Helge
next prev parent reply other threads:[~2026-03-10 17:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 8:56 [PATCH] video: fbdev: omapfb: Add missing error check for clk_get() Chen Ni
2026-03-10 17:42 ` Helge Deller [this message]
2026-03-11 3:28 ` Claude review: " Claude Code Review Bot
2026-03-11 3:28 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b1418319-63d5-4f1a-91dd-ea2e0840663c@gmx.de \
--to=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=nichen@iscas.ac.cn \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox