From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 470C7FD88C2 for ; Wed, 11 Mar 2026 09:01:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A6CB410E39F; Wed, 11 Mar 2026 09:01:44 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="IxaCptpn"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="g3Wj4cKj"; dkim-atps=neutral Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 558EC10E39F for ; Wed, 11 Mar 2026 09:01:43 +0000 (UTC) Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62B4ibdw3893006 for ; Wed, 11 Mar 2026 09:01:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= IjC7zj30dl6fdKiDNAxOGLhU0Og1CDbQKQDvZiwavyI=; b=IxaCptpnszEjfQXz sU+zFc5fXfOwjrHfZ9ZMjOUaYRQ0qGwIFEEnf+mGngbiN9in16sLEYVx6nUagKma TRUPptEBBH+gz4rl1jDwHHoizZMmJFtWrWBPB1HIFsNhykfNqbmxf/VhIYB9CXex c69E3dGnsdt01pgM82VqGHuhlKeqfwn1yKcXaYdG3grQP/MEZiR2fEPcmk6JKqXN iagvzozAlT7JQ/9QC639F65pST7i4S/LWtFsHuMPi8Xsh5JX//SAl4aZQ8ndsxIc ye2gU2z/C1EFv7kQYuHEIgklxlK8dl4PaDOIggmJdvHnytKq0jjk1lctKb0EawTW NVNpDQ== Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ctkmyuxmr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 11 Mar 2026 09:01:42 +0000 (GMT) Received: by mail-vs1-f72.google.com with SMTP id ada2fe7eead31-5ffa8682a68so1334793137.2 for ; Wed, 11 Mar 2026 02:01:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773219702; x=1773824502; darn=lists.freedesktop.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=IjC7zj30dl6fdKiDNAxOGLhU0Og1CDbQKQDvZiwavyI=; b=g3Wj4cKjmjPWy7qAaWeA+J61xNCH2RMmvu8k9DrYt4UgvZpKKV9q01QGQRWj0LHvLO kI6oAd4rRFRrhU12C5Bk1kZx1LjQ0aDpdD74D0C691wxLnhB4QS1zkAKN8+9UUz8/iUE 5Us2MzstOroIrp2/tTMRFaoUCo10VmfYYyR4LmbgUuhrjxvMxdUmSd11P6n2YW1PviND 7+NgXrwKxs6DuAWTiFXgWM4w0zP/XSRhKQod3WJoVvUZTEk2ukWUaaXmfpcS5XfJDQiC TUzgGJqK3BCI/HgOn9whng0l02EsZsPiag9QXix84D9SuQoaiFzJv1/nTvTMFA/gArLU qYQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773219702; x=1773824502; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=IjC7zj30dl6fdKiDNAxOGLhU0Og1CDbQKQDvZiwavyI=; b=D+cmLnB+/SfwhKj7GVSb7eHgUf5pKxDtRVBtmoWbzd/2vEyUi5E8OomuzFRK9ZvgD4 BQ9JhBABCXrK3tbNupZ/mn2MFoQJx58o597bhbU64Zg0ReO/DOzonAMwHOOE1GDjtMpa yvlfvqCWlBypUycXs/mCtL1scsgd8RYnr7Wm7PIWd6cWi1yxEPmVKKYNovgALEQKJBiN wfw+0BdMNFAD+VtlZX5wOu0zzFLU7hpj8bFu9mAn4OT4FZTOob78gpCEoV8KrS2Dx5Oz dMsTWjhLLxC164/ZTCyqk3bmZZKTGzfsQzWjjhhkzO1BwFiLqLf+2+58Zg+fmgo9ee9L XpDA== X-Forwarded-Encrypted: i=1; AJvYcCWjHdiOtmoIxqAsMrqXXzY6PmfRewmH0BGyj5Riipihd0r0+/YcPfwewL5IKzWorN0aiR1nUbkTRnI=@lists.freedesktop.org X-Gm-Message-State: AOJu0Yx0Ge6pl13ULXe76rJbkl1pGHdbPD7ySTbjY04cJx+Q9hErSdie smf06wZxDZtRTPx/ksF/Hq8SRFrUs/zS28cnQypP/9OhJA6ABygjs5aGctzM2D+8wRovyucjXB4 T9iKQwOulrKHrS47UvBlIdV0Se/uBZvs8WTQyXHBBpJ84DNiRwNwvSXkcoBSZwcXUxg224NA= X-Gm-Gg: ATEYQzwbfQOpINxJn2gQUlNYpX/3BhEoJ37st//PJ9pii7zToEFWhIx/WaIYAEjxmwP zKPeV9lBu/rW5g7Lvf73tBPwuoVS9ZEGyu1HsZoSysFO1PV1T84cRHXDLnMkD5IPX0Hbn2m8zmN UvninBfvRUNuda+rPACMNOyvaJNeV2ZfmTry4rpKT3k6BzsEFHyiZhtf30NPwnBfIjEAun6TCoO 3l89cFiihxKzL1hxlXprYFdtbxCJn2vq+1VsNVgzKck1+5sEI98g7YSBGketfpDPvZs9Qq3FITW zpy3tAQn4qMSLzUvoZ4x/oriE3rMm8iv596fi7WzIdeUhilS7O0GNfOodKXYjqOvrBpy6D2cjIo CutUjpcpyVhQP6RQ3bw3/2PJVVjuK/uJWwD7F0Dlk9jl2eQO30fn/XXbj0/lud/YttNGRGTJZgi ZLFPY= X-Received: by 2002:a05:6102:1606:b0:5df:9ae0:45e2 with SMTP id ada2fe7eead31-601dee918e2mr328439137.3.1773219701696; Wed, 11 Mar 2026 02:01:41 -0700 (PDT) X-Received: by 2002:a05:6102:1606:b0:5df:9ae0:45e2 with SMTP id ada2fe7eead31-601dee918e2mr328427137.3.1773219701272; Wed, 11 Mar 2026 02:01:41 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b972e14dc4dsm38046366b.36.2026.03.11.02.01.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Mar 2026 02:01:39 -0700 (PDT) Message-ID: Date: Wed, 11 Mar 2026 10:01:35 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 01/25] drm/msm/mdss: correct UBWC programming sequences To: Dmitry Baryshkov , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Konrad Dybcio , Akhil P Oommen Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260311-ubwc-rework-v2-0-69f718f2a1c9@oss.qualcomm.com> <20260311-ubwc-rework-v2-1-69f718f2a1c9@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260311-ubwc-rework-v2-1-69f718f2a1c9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=RYudyltv c=1 sm=1 tr=0 ts=69b12f76 cx=c_pps a=DUEm7b3gzWu7BqY5nP7+9g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=ICUY2vpjD9Qnjj3NXwQA:9 a=QEXdDO2ut3YA:10 a=-aSRE8QhW-JAV6biHavz:22 X-Proofpoint-GUID: JC8lT-nH_7VH8RQB88sGmjdy__EPem8F X-Proofpoint-ORIG-GUID: JC8lT-nH_7VH8RQB88sGmjdy__EPem8F X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzExMDA3NSBTYWx0ZWRfX59ozyt1S+CCN Q89I+suNjYgpjDAfT3BZZWYUu6wefWvxZyI5sf5O8SfILf2cd+SCxIOmFXdgc10u4SYxsMWu1fI BvUp+x7yzHKLMhHMyukCatpSOh4QrOVIClQQEdoEQQYm9sQ5vzfxzS2lSxcEwodhygA/uJI1yrT F/svW/4pkbviXIrNQAKGLuMt7Ag65mGEcVd1BzCrO+SZxeu/ongS8S1JsUf301+LaH4Es6bRXci WeoDYTa1LmVfdRI7rZ3B4Rabi5rIP33KmiIo22MEnAf3Qj+VCzBc62xvRXoUF+mDLPRSZYvScmU C2Hdfji5XAEoDv5LHWHJ4MDblVEED8UApS01HCvb4xMFlAvDfq0FCtveAamJf6ykmOEXzDJo8sJ Kyw3crA2BVtnliubD4udhoXYc6MV8ixzELIoG5Unq9c/xOfFmsOb3yeXdwQ+o6qjR76s8B7ElXf XJdDxW6YOZAccR6KZAg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-11_01,2026-03-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 impostorscore=0 malwarescore=0 spamscore=0 phishscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603110075 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 3/11/26 4:22 AM, Dmitry Baryshkov wrote: > The UBWC registers in the MDSS region are not dependent on the UBWC > version (it is an invalid assumption we inherited from the vendor SDE > driver). Instead they are dependent only on the MDSS core revision. > > Rework UBWC programming to follow MDSS revision and to use required (aka > encoder) UBWC version instead of the ubwc_dec_version. > > Fixes: d68db6069a8e ("drm/msm/mdss: convert UBWC setup to use match data") > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/msm_mdss.c | 120 ++++++++++++++++------------------------- > 1 file changed, 45 insertions(+), 75 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c > index 9047e8d9ee89..d8b0288f0040 100644 > --- a/drivers/gpu/drm/msm/msm_mdss.c > +++ b/drivers/gpu/drm/msm/msm_mdss.c > @@ -166,27 +166,27 @@ static int _msm_mdss_irq_domain_add(struct msm_mdss *msm_mdss) > return 0; > } > > -static void msm_mdss_setup_ubwc_dec_20(struct msm_mdss *msm_mdss) > +static void msm_mdss_4x_setup_ubwc(struct msm_mdss *msm_mdss) > { > const struct qcom_ubwc_cfg_data *data = msm_mdss->mdss_data; > - u32 value = MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | > + u32 value = MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle & 0x1) | > MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); > > - if (data->ubwc_bank_spread) > - value |= MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; > - > if (data->ubwc_enc_version == UBWC_1_0) > value |= MDSS_UBWC_STATIC_UBWC_MIN_ACC_LEN(1); > > writel_relaxed(value, msm_mdss->mmio + REG_MDSS_UBWC_STATIC); > } > > -static void msm_mdss_setup_ubwc_dec_30(struct msm_mdss *msm_mdss) > +static void msm_mdss_5x_setup_ubwc(struct msm_mdss *msm_mdss) > { > const struct qcom_ubwc_cfg_data *data = msm_mdss->mdss_data; > - u32 value = MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle & 0x1) | > + u32 value = MDSS_UBWC_STATIC_UBWC_SWIZZLE(data->ubwc_swizzle) | > MDSS_UBWC_STATIC_HIGHEST_BANK_BIT(data->highest_bank_bit - 13); > > + if (data->ubwc_bank_spread) > + value |= MDSS_UBWC_STATIC_UBWC_BANK_SPREAD; FWIW neither BANK_SPREAD nor the higher bits of UBWC_SWIZZLE exist on 8150 (MDP 5.0) or 8180 (MDP 5.1). They do on 8250 (MDP 6.0) [...] > + writel_relaxed(ver, msm_mdss->mmio + REG_MDSS_UBWC_CTRL_2); > + writel_relaxed(prediction_mode, msm_mdss->mmio + REG_MDSS_UBWC_PREDICTION_MODE); IDK if this is a concern, but this register has a note "Valid for UBWC_RGB565 only" Konrad