Re: [PATCH] drm/vram: remove DRM_VRAM_MM_FILE_OPERATIONS from docs

[Thomas Zimmermann <tzimmermann@suse.de>]

Am 08.04.26 um 21:31 schrieb Thadeu Lima de Souza Cascardo:
> Commit 02f64b2d8605 ("drm/vram: drop DRM_VRAM_MM_FILE_OPERATIONS") dropped
> DRM_VRAM_MM_FILE_OPERATIONS in preference for using DEFINE_DRM_GEM_OPS.
>
> However, it was not dropped from the kernel docs.
>
> Use DEFINE_DRM_GEM_OPS in the illustration on how to define a
> struct file_operations for such a DRM driver and remove any reference
> to DRM_VRAM_MM_FILE_OPERATIONS.
>
> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>

Thanks for the patch.

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

Fixes: 02f64b2d8605 ("drm/vram: drop DRM_VRAM_MM_FILE_OPERATIONS")



> ---
>   drivers/gpu/drm/drm_gem_vram_helper.c | 7 ++-----
>   1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_gem_vram_helper.c b/drivers/gpu/drm/drm_gem_vram_helper.c
> index d7fcced75e797ce1b86313612a577775c9c26487..bca802ccddee792b8a8f643ecb02a41915f7ba18 100644
> --- a/drivers/gpu/drm/drm_gem_vram_helper.c
> +++ b/drivers/gpu/drm/drm_gem_vram_helper.c
> @@ -49,15 +49,12 @@ static const struct drm_gem_object_funcs drm_gem_vram_object_funcs;
>    * To initialize the VRAM helper library call drmm_vram_helper_init().
>    * The function allocates and initializes an instance of &struct drm_vram_mm
>    * in &struct drm_device.vram_mm . Use &DRM_GEM_VRAM_DRIVER to initialize
> - * &struct drm_driver and  &DRM_VRAM_MM_FILE_OPERATIONS to initialize
> + * &struct drm_driver and &DEFINE_DRM_GEM_FOPS to define
>    * &struct file_operations; as illustrated below.
>    *
>    * .. code-block:: c
>    *
> - *	struct file_operations fops ={
> - *		.owner = THIS_MODULE,
> - *		DRM_VRAM_MM_FILE_OPERATION
> - *	};
> + *	DEFINE_DRM_GEM_FOPS(fops);
>    *	struct drm_driver drv = {
>    *		.driver_feature = DRM_ ... ,
>    *		.fops = &fops,
>
> ---
> base-commit: 408df6213f56f467675dc0ecf156a8bd1984555e
> change-id: 20260408-drm_gem_vram_helper_docs-bc7f30f9c561
>
> Best regards,

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)