From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5818EF3D611 for ; Sun, 29 Mar 2026 17:43:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5704910E075; Sun, 29 Mar 2026 17:42:59 +0000 (UTC) Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) by gabe.freedesktop.org (Postfix) with ESMTPS id 12B6D10E075 for ; Sun, 29 Mar 2026 17:42:58 +0000 (UTC) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w6u9a-0005oB-Tb; Sun, 29 Mar 2026 19:42:26 +0200 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w6u9Y-002kG2-08; Sun, 29 Mar 2026 19:42:24 +0200 Received: from mfe by pty.whiteo.stw.pengutronix.de with local (Exim 4.98.2) (envelope-from ) id 1w6u9X-0000000CZdt-3qYo; Sun, 29 Mar 2026 19:42:23 +0200 Date: Sun, 29 Mar 2026 19:42:23 +0200 From: Marco Felsch To: Liu Ying Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marek Vasut , Laurentiu Palcu , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: display: bridge: ldb: Require reg property only for i.MX6SX/8MP LDBs Message-ID: References: <20260329-fsl_ldb_schema_fix-v1-1-351372754bc0@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260329-fsl_ldb_schema_fix-v1-1-351372754bc0@nxp.com> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Liu, sorry for not writting back earlier, the last weeks were quite busy. On 26-03-29, Liu Ying wrote: > LDB's parent device could be a syscon which doesn't allow a reg property > to be present in it's child devices, e.g., NXP i.MX93 Media blk-ctrl > has a child device NXP i.MX93 Parallel Display Format Configuration(PDFC) > without a reg property(LDB is also a child device of the Media blk-ctrl). > To make the LDB schema be able to describe LDBs without the reg property > like i.MX93 LDB, require the reg property only for i.MX6SX/8MP LDBs. NACK, we want to describe the HW and from HW PoV the LDB is and was always part of a syscon. This is the case for all SoCs i.MX6SX/8MP/93. > Fixes: 8aa2f0ac08d3 ("dt-bindings: display: bridge: ldb: Add check for reg and reg-names") Therefore I would just revert this patch completely. Regards, Marco > Signed-off-by: Liu Ying > --- > .../bindings/display/bridge/fsl,ldb.yaml | 23 ++++++++++++++++------ > 1 file changed, 17 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml > index 7f380879fffd..5f6dc2b11d7b 100644 > --- a/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/fsl,ldb.yaml > @@ -28,6 +28,7 @@ properties: > const: ldb > > reg: > + minItems: 1 > maxItems: 2 > > reg-names: > @@ -68,7 +69,6 @@ required: > - compatible > - clocks > - ports > - - reg > > allOf: > - if: > @@ -83,12 +83,23 @@ allOf: > ports: > properties: > port@2: false > + > - if: > - not: > - properties: > - compatible: > - contains: > - const: fsl,imx6sx-ldb > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx6sx-ldb > + - fsl,imx8mp-ldb > + then: > + required: > + - reg > + > + - if: > + properties: > + compatible: > + contains: > + const: fsl,imx8mp-ldb > then: > required: > - reg-names > > --- > base-commit: 3b058d1aeeeff27a7289529c4944291613b364e9 > change-id: 20260329-fsl_ldb_schema_fix-4fe01c42bff3 > > Best regards, > -- > Liu Ying > > -- #gernperDu #CallMeByMyFirstName Pengutronix e.K. | | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |