From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22BBDCD6E64 for ; Wed, 3 Jun 2026 10:30:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 733F510FB75; Wed, 3 Jun 2026 10:30:47 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="ZUiWkIGH"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 634A410FB75; Wed, 3 Jun 2026 10:30:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780482646; x=1812018646; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=+o0nU3Fx162eyxsoNvnUFfGHK6gbbBVlEk6LSDt3N2c=; b=ZUiWkIGHmk/bUVgbWAGjjWQ7oV1KPGCv2l53nUMAzxpfHEfsX3meHRIz ecqjN62W0BPBsZFaA/KPbbfnht8fAolZJWyntiEIAPTZETI0dnR4izlEC Xzyv2eUHfHHO8gnMA9BUcPXg1ocMq3+vWjJ5HinZQ7qtILHxnnW/7BHHz bSC+63x6ZDGGsloYMpiDe9d2FuIF0mD7a7F6pIMaq3/EWTqfzBFCdWzM2 /STPi9cIKRWWJC3Lf6/ea4ascKFSp7lA3kZ1SXdP9PdVYa5jPA31uSoPw 4RQsRyTEeefDjXJWwrc+kNeDTxnLo2FMaeMp94mUmV66mRuBpjJxJJEb2 A==; X-CSE-ConnectionGUID: Em1e7Q7LSYqgBrfss2OeFg== X-CSE-MsgGUID: 4rlTbaCwTq6K4vhTmuywCA== X-IronPort-AV: E=McAfee;i="6800,10657,11805"; a="81316526" X-IronPort-AV: E=Sophos;i="6.24,185,1774335600"; d="scan'208";a="81316526" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa108.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2026 03:30:45 -0700 X-CSE-ConnectionGUID: Cq9ieJebQ+KCsjOczaBhsA== X-CSE-MsgGUID: +31VtOuHS1mBytnk9wzvcg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,185,1774335600"; d="scan'208";a="249104959" Received: from abityuts-desk.ger.corp.intel.com (HELO localhost) ([10.245.244.189]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2026 03:30:41 -0700 From: Jani Nikula To: Thomas Zimmermann , rajat.gupta@oss.qualcomm.com, jani.saarinen@intel.com, simona@ffwll.ch, airlied@gmail.com, mripard@kernel.org, maarten.lankhorst@linux.intel.com Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, Thomas Zimmermann Subject: Re: [PATCH] drm/dumb-buffer: Drop buffer-size limits for now In-Reply-To: <20260602112842.252279-1-tzimmermann@suse.de> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20260602112842.252279-1-tzimmermann@suse.de> Date: Wed, 03 Jun 2026 13:30:37 +0300 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 02 Jun 2026, Thomas Zimmermann wrote: > The size limits break some of the CI tests. So drop them for now. Keep > the other overflow tests from commit 5ab62dd3687b ("drm: prevent integer > overflows in dumb buffer creation helpers") in place. > > There is still a pre-existing overflow check for 32-bit type limits in > drm_mode_create_dumb() that will catch the really absurd size requests. > Drivers that still do not use drm_mode_size_dumb() should be updated. The > helper calculates dumb-buffer geometry with overflow checks. > > Signed-off-by: Thomas Zimmermann > Fixes: 5ab62dd3687b ("drm: prevent integer overflows in dumb buffer creation helpers") > Reported-by: Jani Nikula > Closes: https://lore.kernel.org/dri-devel/ddf0233e50044059c85279f928661563ef6a55bf@intel.com/ > Cc: Rajat Gupta > Cc: Thomas Zimmermann > Cc: Maarten Lankhorst > Cc: Maxime Ripard Thanks for following up. Maybe we need to return to this with less urgency. Acked-by: Jani Nikula > --- > drivers/gpu/drm/drm_dumb_buffers.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/gpu/drm/drm_dumb_buffers.c b/drivers/gpu/drm/drm_dumb_buffers.c > index e60130b2bb0c..8e9ff17538e7 100644 > --- a/drivers/gpu/drm/drm_dumb_buffers.c > +++ b/drivers/gpu/drm/drm_dumb_buffers.c > @@ -201,13 +201,6 @@ int drm_mode_create_dumb(struct drm_device *dev, > if (!args->width || !args->height || !args->bpp) > return -EINVAL; > > - /* Reject unreasonable inputs early. Dumb buffers are for software > - * rendering; nothing legitimate needs more than 8192x8192 at 32bpp. > - * This prevents overflows in downstream alignment helpers. > - */ > - if (args->width >= 8192 || args->height >= 8192 || args->bpp > 32) > - return -EINVAL; > - > /* overflow checks for 32bit size calculations */ > if (args->bpp > U32_MAX - 8) > return -EINVAL; > > base-commit: a980196655477a8f5067112946401fe52e510664 -- Jani Nikula, Intel