public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: Maxime Ripard <mripard@kernel.org>,
	Matthew Brost <matthew.brost@intel.com>,
	Danilo Krummrich <dakr@kernel.org>,
	Philipp Stanner <phasta@kernel.org>,
	Christian Koenig <christian.koenig@amd.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Matthew Auld <matthew.auld@intel.com>,
	Arun Pravin <arunpravin.paneerselvam@amd.com>
Cc: Simona Vetter <simona.vetter@ffwll.ch>,
	David Airlie <airlied@gmail.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/tests: Mark slow tests as slow
Date: Tue, 24 Feb 2026 12:12:31 +0100	[thread overview]
Message-ID: <db1ca847-7ab7-43ab-b315-ba377e0d2ceb@suse.de> (raw)
In-Reply-To: <20260224110310.1854608-1-mripard@kernel.org>



Am 24.02.26 um 12:03 schrieb Maxime Ripard:
> Some DRM tests cross the 1s execution time threshold that defines a test
> as slow. Let's flag them as such.
>
> Signed-off-by: Maxime Ripard <mripard@kernel.org>

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

> ---
>   drivers/gpu/drm/scheduler/tests/tests_basic.c | 4 ++--
>   drivers/gpu/drm/tests/drm_buddy_test.c        | 2 +-
>   2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/scheduler/tests/tests_basic.c b/drivers/gpu/drm/scheduler/tests/tests_basic.c
> index 82a41a456b0a..a5a5a35a87b0 100644
> --- a/drivers/gpu/drm/scheduler/tests/tests_basic.c
> +++ b/drivers/gpu/drm/scheduler/tests/tests_basic.c
> @@ -419,11 +419,11 @@ static void drm_sched_change_priority(struct kunit *test)
>   		drm_mock_sched_entity_free(entity[i]);
>   }
>   
>   static struct kunit_case drm_sched_priority_tests[] = {
>   	KUNIT_CASE(drm_sched_priorities),
> -	KUNIT_CASE(drm_sched_change_priority),
> +	KUNIT_CASE_SLOW(drm_sched_change_priority),
>   	{}
>   };
>   
>   static struct kunit_suite drm_sched_priority = {
>   	.name = "drm_sched_basic_priority_tests",
> @@ -544,11 +544,11 @@ static void drm_sched_test_credits(struct kunit *test)
>   	drm_mock_sched_entity_free(entity);
>   	drm_mock_sched_fini(sched);
>   }
>   
>   static struct kunit_case drm_sched_credits_tests[] = {
> -	KUNIT_CASE(drm_sched_test_credits),
> +	KUNIT_CASE_SLOW(drm_sched_test_credits),
>   	{}
>   };
>   
>   static struct kunit_suite drm_sched_credits = {
>   	.name = "drm_sched_basic_credits_tests",
> diff --git a/drivers/gpu/drm/tests/drm_buddy_test.c b/drivers/gpu/drm/tests/drm_buddy_test.c
> index e6f8459c6c54..35ca79525f43 100644
> --- a/drivers/gpu/drm/tests/drm_buddy_test.c
> +++ b/drivers/gpu/drm/tests/drm_buddy_test.c
> @@ -908,11 +908,11 @@ static struct kunit_case drm_buddy_tests[] = {
>   	KUNIT_CASE(drm_test_buddy_alloc_pessimistic),
>   	KUNIT_CASE(drm_test_buddy_alloc_pathological),
>   	KUNIT_CASE(drm_test_buddy_alloc_contiguous),
>   	KUNIT_CASE(drm_test_buddy_alloc_clear),
>   	KUNIT_CASE(drm_test_buddy_alloc_range_bias),
> -	KUNIT_CASE(drm_test_buddy_fragmentation_performance),
> +	KUNIT_CASE_SLOW(drm_test_buddy_fragmentation_performance),
>   	KUNIT_CASE(drm_test_buddy_alloc_exceeds_max_order),
>   	{}
>   };
>   
>   static struct kunit_suite drm_buddy_test_suite = {

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)



  reply	other threads:[~2026-02-24 11:12 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-24 11:03 [PATCH] drm/tests: Mark slow tests as slow Maxime Ripard
2026-02-24 11:12 ` Thomas Zimmermann [this message]
2026-02-24 11:43 ` Danilo Krummrich
2026-02-24 12:29   ` Tvrtko Ursulin
2026-02-24 12:44     ` Philipp Stanner
2026-02-24 12:49 ` Tvrtko Ursulin
2026-02-26 10:56   ` Maxime Ripard
2026-02-26 12:42     ` Tvrtko Ursulin
2026-02-26 12:48       ` Philipp Stanner
2026-02-26 13:02         ` Tvrtko Ursulin
2026-02-26 13:17           ` Philipp Stanner
2026-02-26 13:23             ` Tvrtko Ursulin
2026-02-24 13:07 ` Arunpravin Paneer Selvam
2026-02-27  5:13 ` Claude review: " Claude Code Review Bot
2026-02-27  5:13 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=db1ca847-7ab7-43ab-b315-ba377e0d2ceb@suse.de \
    --to=tzimmermann@suse.de \
    --cc=airlied@gmail.com \
    --cc=arunpravin.paneerselvam@amd.com \
    --cc=christian.koenig@amd.com \
    --cc=dakr@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=matthew.auld@intel.com \
    --cc=matthew.brost@intel.com \
    --cc=mripard@kernel.org \
    --cc=phasta@kernel.org \
    --cc=simona.vetter@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox