From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C590FCE068 for ; Thu, 26 Feb 2026 12:42:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0754E10E91C; Thu, 26 Feb 2026 12:42:45 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=ursulin.net header.i=@ursulin.net header.b="fpuN7TDX"; dkim-atps=neutral Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8D43910E91C for ; Thu, 26 Feb 2026 12:42:43 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id ffacd0b85a97d-43767807da6so562357f8f.2 for ; Thu, 26 Feb 2026 04:42:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ursulin.net; s=google; t=1772109762; x=1772714562; darn=lists.freedesktop.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=WQHxFVgkVIjYGs/6VmXelQKxhGU90iorAtclYRjIzes=; b=fpuN7TDXTg8jJnMZKHXkkgDorYBK7uufb7ZIL/TO8WUTFz1FTnsGbBpVw8nqQSPx/q 3TGoDrBx8FTpDWE5+eelmDUMPozswcH8+WGBhtR8YzUwDzrPaMOgEsBq7EXOf/HDYCtl lhVPVhUjofz809bfx6Gy33MHiPWXZ2qG7DSk5glnzhdylnUqEcSSIP93Wr66wpK/VUfN XpDEYU9M8VMBE37StwNFwi65wYgykeCD3DdOgzfLgbUbc0TX4a3gT95Owuz231Nex5Ey JOZ2GS9/oz0+VJwnUbINmH8TmsQua7V5gG4js6zkwbpDJcm56V56Vk23cWhCofSsZU6i Agug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772109762; x=1772714562; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WQHxFVgkVIjYGs/6VmXelQKxhGU90iorAtclYRjIzes=; b=rA9b0RKQ4b0wPZjEUtElpU2801NftUkX/wMKKqpWU/Y1BJ+9LyANWdDS2xRx4VJKEI ud0oHwmJ4e/MrnJXE7m3bktYgRlv+e+eimAZR3WinjN02wIXv24XHtaDnUdVoWsfHuUl an1FlIOzBP4i1nV3LTbpP+AGAPNu5NaLSwivt+CYCoU6KxhCaZQmQNVVxaQPBrqM1D/h gCE2CGzDEct16PYNPJYOk5KHE2HmHvhvhI/JVQIxJ87nTvg1Ip/glePsNcCYds4hRyFv ZTkycYFKBc8lTuTHSq7kFhYiYWCCj3EgS4XB2sdg1nlDngJKJfFfvLyy5TTSrfuJkrlY O4IA== X-Forwarded-Encrypted: i=1; AJvYcCU+cbdWO7ZVQcc67NrHmEBQrUrE9m2B/vatM/HDB3enHQMW3ah4L1pz0SDsf91vxAdnDlAdXaP/YX0=@lists.freedesktop.org X-Gm-Message-State: AOJu0YwqBhwGlKzxYZsnc8IsAxu200Q0cUV++o1vgufzVPPEV83GGjdp H/MAYcCoMnXe4jCgMuo1T3VqYjT4tmYTI5XqYfk2tVz4gkjC82aDiJWXjhOzRturfBc= X-Gm-Gg: ATEYQzwDJhDHBq6DWYaMgv0/oEsmfecNBkALPTp/cy++Jp7nFu0nBuxfH5LIQ64r+z4 +3qu1htuCa0bdfb3+ook6pItsjY9L4Brt1tGWY46QN7BjHpbWw0CTC7dX60AJ82Mmltbji9EfmL HHlFtCakMGwJ9iJkZyTZJXN3SkOnGycHko9FrhguDok0ZPvNOlmHvJiOzxGyBZixKBBGOfOQfg/ dCO7YjjW2SEvjI5kZxbEfDS4nKFGv3zGyUvl8htosrMoKBJJA/h7KX/UTpYGP8LrMDX6D31MwKS JfzK8pWK3UHcoSNjE3SUUfYfDv2cCsy97od1UVk8vMCnyhpY0ZLTg4UwUzfVBY4PO0RRcr7Ygup wgMDJ7uFgOLqfmC6Fa9SnE8R6xHKCtyqlskA4fFOfFiTcACkYfQFZiD7krD477OMV4U21M9tjnG 3/B0IXK2oENJRp95NcG2jZEBMqaxpnULBUwHrvUsxuhkxBdv66m81hVUI= X-Received: by 2002:a05:6000:4d:b0:439:98b8:649a with SMTP id ffacd0b85a97d-43998b868d6mr2582426f8f.47.1772109761783; Thu, 26 Feb 2026 04:42:41 -0800 (PST) Received: from [192.168.0.101] ([90.240.106.137]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43970d3ff6dsm42326785f8f.25.2026.02.26.04.42.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Feb 2026 04:42:40 -0800 (PST) Message-ID: Date: Thu, 26 Feb 2026 12:42:39 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] drm/tests: Mark slow tests as slow To: Maxime Ripard Cc: Matthew Brost , Danilo Krummrich , Philipp Stanner , Christian Koenig , Maarten Lankhorst , Thomas Zimmermann , Matthew Auld , Arun Pravin , Simona Vetter , David Airlie , dri-devel@lists.freedesktop.org References: <20260224110310.1854608-1-mripard@kernel.org> <1c76b8d6-9394-4017-a18f-95ecc2c08175@ursulin.net> <20260226-certain-tuscan-caribou-ba4c5e@penduick> Content-Language: en-GB From: Tvrtko Ursulin In-Reply-To: <20260226-certain-tuscan-caribou-ba4c5e@penduick> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 26/02/2026 10:56, Maxime Ripard wrote: > Hi Tvrtko, > > On Tue, Feb 24, 2026 at 12:49:01PM +0000, Tvrtko Ursulin wrote: >> >> On 24/02/2026 11:03, Maxime Ripard wrote: >>> Some DRM tests cross the 1s execution time threshold that defines a test >>> as slow. Let's flag them as such. >> >> Curious that both did not trigger for me and I even run them under nested >> qemu most of the time. >> >>> Signed-off-by: Maxime Ripard >>> --- >>> drivers/gpu/drm/scheduler/tests/tests_basic.c | 4 ++-- >>> drivers/gpu/drm/tests/drm_buddy_test.c | 2 +- >>> 2 files changed, 3 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/scheduler/tests/tests_basic.c b/drivers/gpu/drm/scheduler/tests/tests_basic.c >>> index 82a41a456b0a..a5a5a35a87b0 100644 >>> --- a/drivers/gpu/drm/scheduler/tests/tests_basic.c >>> +++ b/drivers/gpu/drm/scheduler/tests/tests_basic.c >>> @@ -419,11 +419,11 @@ static void drm_sched_change_priority(struct kunit *test) >>> drm_mock_sched_entity_free(entity[i]); >>> } >>> static struct kunit_case drm_sched_priority_tests[] = { >>> KUNIT_CASE(drm_sched_priorities), >>> - KUNIT_CASE(drm_sched_change_priority), >>> + KUNIT_CASE_SLOW(drm_sched_change_priority), >> >> This one deliberately aims to run for ~1s and I don't have an immediate idea >> how it would go over 2s. > > 1s is the threshold for a slow test: > https://elixir.bootlin.com/linux/v6.19.3/source/lib/kunit/test.c#L365 > > It only warns about it if it crosses 2s, but if it's expected to take > 1s, it should be flagged as such still. I know, just curious which environment managed to trigger the warning. Because I thought my test setup was the slowest one (nested virtualization - qemu-system inside vmware). >>> {} >>> }; >>> static struct kunit_suite drm_sched_priority = { >>> .name = "drm_sched_basic_priority_tests", >>> @@ -544,11 +544,11 @@ static void drm_sched_test_credits(struct kunit *test) >>> drm_mock_sched_entity_free(entity); >>> drm_mock_sched_fini(sched); >>> } >>> static struct kunit_case drm_sched_credits_tests[] = { >>> - KUNIT_CASE(drm_sched_test_credits), >>> + KUNIT_CASE_SLOW(drm_sched_test_credits), >> >> Same really. >> >> Anyway, the scheduler parts LGTM and I can follow up trying to optimise >> these two later. >> >> For the scheduler: >> >> Reviewed-by: Tvrtko Ursulin > > Thanks! I have a patch already which makes those (and one more) test cases faster, but I will wait sending it until you merge this one. Regards, Tvrtko