From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0DF4EDEC02 for ; Wed, 4 Mar 2026 03:35:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 240DD10E943; Wed, 4 Mar 2026 03:35:10 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="nvWFf65B"; dkim-atps=neutral Received: from mail-ot1-f53.google.com (mail-ot1-f53.google.com [209.85.210.53]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2C22710E942 for ; Wed, 4 Mar 2026 03:35:08 +0000 (UTC) Received: by mail-ot1-f53.google.com with SMTP id 46e09a7af769-7d18a9d2b1aso6111980a34.2 for ; Tue, 03 Mar 2026 19:35:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1772595307; x=1773200107; darn=lists.freedesktop.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NrE0zI+7ilR1NedBJHHio8t27882PDymrHrpls6UPoo=; b=nvWFf65BE/T93AHTd2UMUuktkwbY3/+fvDNLsMCEkX0TdgQ8Cdhtbhr/t4IM4GZM+8 H0deP80oHFIXdIEzWhmQQpNe/U5asluUiWaRtwatESa7FhSauZT2BipV+buXdQ9J1c7K jc5Y8FWdwczuvMnW3bSrf6jzafBcqLd43uYjBZIhvQDyd+u+87u3nErgp43RY2Crf9RZ GLoO43/tFLF5y56U/Zyrm1XoG7eeaoFuQuHTpzuKb2aYwYF89/fTrWNJOiB7uCUBTwiS tBHWvUSYu+ScGlp/R3TzV+XJKX0hAPv5wFJ4BMGoacXN/GwzTiDo9Kgg5wOYrcSKDDhI 190w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772595307; x=1773200107; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NrE0zI+7ilR1NedBJHHio8t27882PDymrHrpls6UPoo=; b=I8kyzDI/lHFJ6EBih8FUa/g8nqS1cZOS08T5zLIqWLXXzQfkcVtxvzqSKxsAA6bfL3 enPc/OcoWaZRH/gQ8w+OePbJpl1m5xSvPwY6CdrvNaEKSM3yvWjQjw7b+FDYJ/dutNHr k0lVleNchzGsl3uC07heQyqIk9M3q7oglUaJjwlFvG/PluzJBXbaaWa3jBxai2/zlKu3 NxEOgIFs80M1U+uFNiWmWEqrGWoO33+Uvcj/w0QENnOA/hOnsS8QK/wR4ETnCOOj+UIr MYrZxBASw5pvbeZWUiBwszjiXRDZ+zeO9YAypQRIfCWyeuiONzX6OAyYIrLFmEhaILtP Oxqg== X-Forwarded-Encrypted: i=1; AJvYcCXUiPUsPbOBeOkbRCRXkFfvHyDv8QfWTiidvS1VVZwv3OwsIBNdJlQ3ZSoBP76o4CFmsuJQMk+C7X0=@lists.freedesktop.org X-Gm-Message-State: AOJu0YwnzWGuAGm06gcPbPRPypj986OShlzEKvyZS+e1WN7ZggBxLnGa KqCgJhBaQvhG429xu+2zv3P3vqQV/88mf2gs7wRj5W0BVIAfq5oD1TWvycnOCGx4dW8= X-Gm-Gg: ATEYQzx1nLbVrd1zK69op5+NYuXaEFqmZoxaRoeMOARFcAhyhwfBEJfKwjhgWdXn9um vrldgMQL20YuLwQaI9ifDRUq/ACwGBg7tyTGYYKTFboHvzyJqFvb2MzFVLqhZu1+HsX/AXQV46N iOFzxJr48C9IYnYw08Kq14nnQQlmmOpoZVuEMMiVA8wspt/ACRveLyfbttyGQShYHrTCL22GJaS pz0UqgbVWA4Kjga1KnZsYxA4Y3PTCU3beQnXVa2c3Y0PldF+SF9gbG5IzECS6eOxUjosWITZjI6 ZWPkHAE8veKfCOe1m10BJLwhXWbUPvrTXKDRLLtEyLI3NZ4amt7ZWNd6SdpaE1BBq7J+brlSM80 7aowBnHJxyBGX9rCMSpAeOsXeRtZdnQh9aAPg7PaQSvKso7tqEHFbKAnX7iUfLeBkhdpg/1fYXY uYOuPDGDPFaKA8RnWVUwz8qNdeL8tlKLGVXugSz/hxsqr6EdZ5V6lvrVrZ5wkHReef71jLva9U0 6bsWM+bfQ== X-Received: by 2002:a05:6830:6185:b0:7c7:6977:17cb with SMTP id 46e09a7af769-7d6d139f788mr450044a34.21.1772595307034; Tue, 03 Mar 2026 19:35:07 -0800 (PST) Received: from [192.168.1.150] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7d586653f6asm15202012a34.19.2026.03.03.19.35.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Mar 2026 19:35:06 -0800 (PST) Message-ID: Date: Tue, 3 Mar 2026 20:35:01 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/8] mm: globalize rest_of_page() macro To: Yury Norov , Sean Christopherson Cc: Jakub Kicinski , Andrew Morton , "David S. Miller" , "Michael S. Tsirkin" , Theodore Ts'o , Albert Ou , Alexander Duyck , Alexander Gordeev , Alexander Viro , Alexandra Winter , Andreas Dilger , Andrew Lunn , Anna Schumaker , Anton Yakovlev , Arnaldo Carvalho de Melo , Aswin Karuvally , Borislav Petkov , Carlos Maiolino , Catalin Marinas , Chao Yu , Christian Borntraeger , Christian Brauner , Claudio Imbrenda , Dave Hansen , David Airlie , Dominique Martinet , Dongsheng Yang , Eric Dumazet , Eric Van Hensbergen , Heiko Carstens , Herbert Xu , Ingo Molnar , Jaegeuk Kim , Jani Nikula , Janosch Frank , Jaroslav Kysela , Joonas Lahtinen , Latchesar Ionkov , Linus Walleij , Madhavan Srinivasan , Mark Brown , Michael Ellerman , Miklos Szeredi , Namhyung Kim , Palmer Dabbelt , Paolo Abeni , Paolo Bonzini , Paul Walmsley , Peter Zijlstra , Rodrigo Vivi , Simona Vetter , Takashi Iwai , Thomas Gleixner , Trond Myklebust , Tvrtko Ursulin , Vasily Gorbik , Will Deacon , Yury Norov , Zheng Gu , linux-kernel@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-block@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, dm-devel@lists.linux.dev, netdev@vger.kernel.org, linux-spi@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-crypto@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, v9fs@lists.linux.dev, virtualization@lists.linux.dev, linux-sound@vger.kernel.org References: <20260304012717.201797-1-ynorov@nvidia.com> <20260303182845.250bb2de@kernel.org> Content-Language: en-US From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 3/3/26 8:32 PM, Yury Norov wrote: > My motivation is that it helps to simplify constructions like this: > > - loff_t cmp_len = min(PAGE_SIZE - offset_in_page(srcoff), > - PAGE_SIZE - offset_in_page(dstoff)); > + loff_t cmp_len = min(rest_of_page(srcoff), rest_of_page(dstoff)); > > Or this: > > - if (folio_test_highmem(dst_folio) && > - chunk > PAGE_SIZE - offset_in_page(dst_off)) > - chunk = PAGE_SIZE - offset_in_page(dst_off); > - if (folio_test_highmem(src_folio) && > - chunk > PAGE_SIZE - offset_in_page(src_off)) > - chunk = PAGE_SIZE - offset_in_page(src_off); > + if (folio_test_highmem(dst_folio) && chunk > rest_of_page(dst_off)) > + chunk = rest_of_page(dst_off); > + if (folio_test_highmem(src_folio) && chunk > rest_of_page(src_off)) > + chunk = rest_of_page(src_off); > > To a point where I don't have to use my brains to decode them. I agree > it's an easy math. It's just too bulky to my (and 9p guys too) taste. The thing is, now I have to go lookup what on earth rest_of_page() does, whereas PAGE_SIZE - offset_in_page(page) is immediately obvious. It's a classic case of "oh let's add this helper to simplify things" which really just makes it worse, because now you have to jump to the definition of rest_of_page(). IOW, just no. -- Jens Axboe