public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH drm-misc-next] drm: verisilicon: assign git tree to drm/misc in MAINTAINERS
@ 2026-02-10 14:15 Icenowy Zheng
  2026-02-10 14:41 ` Thomas Zimmermann
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Icenowy Zheng @ 2026-02-10 14:15 UTC (permalink / raw)
  To: Icenowy Zheng, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann, David Airlie, Simona Vetter
  Cc: dri-devel, linux-kernel

Like other SoC display controllers, patches for the verisilicon driver
go through the drm/misc tree.

Add the T: clause to the MAINTAINERS item.

Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index f2bec2c0d7e39..4a2d5e8f0f630 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8682,6 +8682,7 @@ DRM DRIVERS FOR VERISILICON DISPLAY CONTROLLER IP
 M:	Icenowy Zheng <zhengxingda@iscas.ac.cn>
 L:	dri-devel@lists.freedesktop.org
 S:	Maintained
+T:	git https://gitlab.freedesktop.org/drm/misc/kernel.git
 F:	Documentation/devicetree/bindings/display/verisilicon,dc.yaml
 F:	drivers/gpu/drm/verisilicon/
 
-- 
2.52.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH drm-misc-next] drm: verisilicon: assign git tree to drm/misc in MAINTAINERS
  2026-02-10 14:15 [PATCH drm-misc-next] drm: verisilicon: assign git tree to drm/misc in MAINTAINERS Icenowy Zheng
@ 2026-02-10 14:41 ` Thomas Zimmermann
  2026-02-11  6:22 ` Claude review: " Claude Code Review Bot
  2026-02-11  6:22 ` Claude Code Review Bot
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Zimmermann @ 2026-02-10 14:41 UTC (permalink / raw)
  To: Icenowy Zheng, Maarten Lankhorst, Maxime Ripard, David Airlie,
	Simona Vetter
  Cc: dri-devel, linux-kernel



Am 10.02.26 um 15:15 schrieb Icenowy Zheng:
> Like other SoC display controllers, patches for the verisilicon driver
> go through the drm/misc tree.
>
> Add the T: clause to the MAINTAINERS item.
>
> Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>

Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

> ---
>   MAINTAINERS | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index f2bec2c0d7e39..4a2d5e8f0f630 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -8682,6 +8682,7 @@ DRM DRIVERS FOR VERISILICON DISPLAY CONTROLLER IP
>   M:	Icenowy Zheng <zhengxingda@iscas.ac.cn>
>   L:	dri-devel@lists.freedesktop.org
>   S:	Maintained
> +T:	git https://gitlab.freedesktop.org/drm/misc/kernel.git
>   F:	Documentation/devicetree/bindings/display/verisilicon,dc.yaml
>   F:	drivers/gpu/drm/verisilicon/
>   

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)




^ permalink raw reply	[flat|nested] 4+ messages in thread

* Claude review: drm: verisilicon: assign git tree to drm/misc in MAINTAINERS
  2026-02-10 14:15 [PATCH drm-misc-next] drm: verisilicon: assign git tree to drm/misc in MAINTAINERS Icenowy Zheng
  2026-02-10 14:41 ` Thomas Zimmermann
@ 2026-02-11  6:22 ` Claude Code Review Bot
  2026-02-11  6:22 ` Claude Code Review Bot
  2 siblings, 0 replies; 4+ messages in thread
From: Claude Code Review Bot @ 2026-02-11  6:22 UTC (permalink / raw)
  To: dri-devel-reviews

Overall Series Review

Subject: drm: verisilicon: assign git tree to drm/misc
 in MAINTAINERS
Author: Icenowy Zheng <zhengxingda@iscas.ac.cn>
Patches: 2
Reviewed: 2026-02-11T16:22:52.716279

---

This is a single-patch series that adds the git tree reference to the MAINTAINERS entry for the DRM VERISILICON DISPLAY CONTROLLER IP driver. The change is trivial and administrative in nature, correctly documenting that this driver follows the drm/misc workflow like other SoC display controllers.

**Summary:**
- **Scope:** Administrative MAINTAINERS file update
- **Impact:** Documentation only - no functional code changes
- **Quality:** Correct and minimal change
- **Status:** Already has Reviewed-by tag from Thomas Zimmermann (DRM maintainer)

The patch has already received a Reviewed-by from Thomas Zimmermann, a core DRM maintainer, which is appropriate for this type of change.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Claude review: drm: verisilicon: assign git tree to drm/misc in MAINTAINERS
  2026-02-10 14:15 [PATCH drm-misc-next] drm: verisilicon: assign git tree to drm/misc in MAINTAINERS Icenowy Zheng
  2026-02-10 14:41 ` Thomas Zimmermann
  2026-02-11  6:22 ` Claude review: " Claude Code Review Bot
@ 2026-02-11  6:22 ` Claude Code Review Bot
  2 siblings, 0 replies; 4+ messages in thread
From: Claude Code Review Bot @ 2026-02-11  6:22 UTC (permalink / raw)
  To: dri-devel-reviews

Patch Review

**Metadata:**
- Author: Icenowy Zheng <zhengxingda@iscas.ac.cn>
- Date: Tue, 10 Feb 2026 22:15:37 +0800
- Message-ID: <20260210141537.752890-1-zhengxingda@iscas.ac.cn>
- Target: drm-misc-next

**Commit Message Analysis:**
```
Like other SoC display controllers, patches for the verisilicon driver
go through the drm/misc tree.

Add the T: clause to the MAINTAINERS item.

Signed-off-by: Icenowy Zheng <zhengxingda@iscas.ac.cn>
```

The commit message is clear and adequate for this administrative change. It provides the rationale (consistency with other SoC display controllers) and describes the action taken.

**Code Review:**

```diff
@@ -8682,6 +8682,7 @@ DRM DRIVERS FOR VERISILICON DISPLAY CONTROLLER IP
 M:	Icenowy Zheng <zhengxingda@iscas.ac.cn>
 L:	dri-devel@lists.freedesktop.org
 S:	Maintained
+T:	git https://gitlab.freedesktop.org/drm/misc/kernel.git
 F:	Documentation/devicetree/bindings/display/verisilicon,dc.yaml
 F:	drivers/gpu/drm/verisilicon/
```

**Analysis:**

✓ **Correct Location:** The T: field is added in the appropriate alphabetical position within the MAINTAINERS entry (after S:, before F: fields), following MAINTAINERS file conventions.

✓ **Correct URL:** The git URL `https://gitlab.freedesktop.org/drm/misc/kernel.git` is the correct drm/misc tree used by other DRM drivers.

✓ **Appropriate Change:** This aligns with the stated workflow where verisilicon patches go through drm/misc, consistent with other SoC display controller drivers.

✓ **Minimal Change:** Only adds the necessary T: line, no extraneous modifications.

**Potential Issues:**

None identified. This is a straightforward administrative change.

**Review Tags Already Present:**
- Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

**Recommendation:**

**Acked-by** - This patch is correct and appropriate for merging. The change properly documents the git workflow for the verisilicon driver, and having Thomas Zimmermann's Reviewed-by (a DRM maintainer) is sufficient authority for this type of administrative change.

No further action needed beyond the existing review tag.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-02-11  6:22 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-10 14:15 [PATCH drm-misc-next] drm: verisilicon: assign git tree to drm/misc in MAINTAINERS Icenowy Zheng
2026-02-10 14:41 ` Thomas Zimmermann
2026-02-11  6:22 ` Claude review: " Claude Code Review Bot
2026-02-11  6:22 ` Claude Code Review Bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox