From: Helge Deller <deller@gmx.de>
To: Thomas Zimmermann <tzimmermann@suse.de>,
Amin GATTOUT <amin.gattout@gmail.com>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fbdev: goldfishfb: use devm_platform_ioremap_resource()
Date: Tue, 3 Mar 2026 15:07:14 +0100 [thread overview]
Message-ID: <ef603e8e-a5f6-4f8a-b538-6535f1b934a2@gmx.de> (raw)
In-Reply-To: <2fb9b0fe-e63a-4b06-968d-3cb30383ba37@suse.de>
On 3/3/26 13:51, Thomas Zimmermann wrote:
> Am 03.03.26 um 13:22 schrieb Amin GATTOUT:
>> Replace the open-coded platform_get_resource() + ioremap() pair with
>> devm_platform_ioremap_resource(), which requests the memory region and
>> maps it in a single call, with automatic cleanup on device removal.
>>
>> Signed-off-by: Amin GATTOUT <amin.gattout@gmail.com>
>
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
>
>> ---
>> drivers/video/fbdev/goldfishfb.c | 14 +++-----------
>> 1 file changed, 3 insertions(+), 11 deletions(-)
applied to fbdev git tree.
Thanks!
Helge
next prev parent reply other threads:[~2026-03-03 14:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 12:22 [PATCH] fbdev: goldfishfb: use devm_platform_ioremap_resource() Amin GATTOUT
2026-03-03 12:51 ` Thomas Zimmermann
2026-03-03 14:07 ` Helge Deller [this message]
2026-03-03 21:21 ` Claude review: " Claude Code Review Bot
2026-03-03 21:21 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef603e8e-a5f6-4f8a-b538-6535f1b934a2@gmx.de \
--to=deller@gmx.de \
--cc=amin.gattout@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox