[PATCH] gpu: nova: rename drivers to use kebab-case convention

[PATCH] gpu: nova: rename drivers to use kebab-case convention

[Cheng-Yang Chou]

Rename nova-core driver from "NovaCore" to "nova-core" and nova-drm
driver from "Nova" to "nova-drm" to follow kernel naming conventions
before these names become UAPI (e.g. exposed via driver_override).

Link: https://github.com/Rust-for-Linux/linux/issues/1228
Signed-off-by: Cheng-Yang Chou <yphbchou0911@gmail.com>
---
 drivers/gpu/drm/nova/driver.rs     | 4 ++--
 drivers/gpu/drm/nova/nova.rs       | 2 +-
 drivers/gpu/nova-core/nova_core.rs | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/nova/driver.rs b/drivers/gpu/drm/nova/driver.rs
index b1af0a099551..addf70c33cb2 100644
--- a/drivers/gpu/drm/nova/driver.rs
+++ b/drivers/gpu/drm/nova/driver.rs
@@ -32,11 +32,11 @@ pub(crate) struct NovaData {
     major: 0,
     minor: 0,
     patchlevel: 0,
-    name: c"nova",
+    name: c"nova-drm",
     desc: c"Nvidia Graphics",
 };
 
-const NOVA_CORE_MODULE_NAME: &CStr = c"NovaCore";
+const NOVA_CORE_MODULE_NAME: &CStr = c"nova-core";
 const AUXILIARY_NAME: &CStr = c"nova-drm";
 
 kernel::auxiliary_device_table!(
diff --git a/drivers/gpu/drm/nova/nova.rs b/drivers/gpu/drm/nova/nova.rs
index 8893e58ee0db..1fd454c7e0df 100644
--- a/drivers/gpu/drm/nova/nova.rs
+++ b/drivers/gpu/drm/nova/nova.rs
@@ -10,7 +10,7 @@
 
 kernel::module_auxiliary_driver! {
     type: NovaDriver,
-    name: "Nova",
+    name: "nova-drm",
     authors: ["Danilo Krummrich"],
     description: "Nova GPU driver",
     license: "GPL v2",
diff --git a/drivers/gpu/nova-core/nova_core.rs b/drivers/gpu/nova-core/nova_core.rs
index c1121e7c64c5..90e98380687b 100644
--- a/drivers/gpu/nova-core/nova_core.rs
+++ b/drivers/gpu/nova-core/nova_core.rs
@@ -22,7 +22,7 @@
 
 kernel::module_pci_driver! {
     type: driver::NovaCore,
-    name: "NovaCore",
+    name: "nova-core",
     authors: ["Danilo Krummrich"],
     description: "Nova Core GPU driver",
     license: "GPL v2",
-- 
2.48.1

Re: [PATCH] gpu: nova: rename drivers to use kebab-case convention

[Timur Tabi]

On Tue, 2026-03-10 at 14:24 +0800, Cheng-Yang Chou wrote:
> Rename nova-core driver from "NovaCore" to "nova-core" and nova-drm
> driver from "Nova" to "nova-drm" to follow kernel naming conventions
> before these names become UAPI (e.g. exposed via driver_override).
> 
> Link: https://github.com/Rust-for-Linux/linux/issues/1228
> Signed-off-by: Cheng-Yang Chou <yphbchou0911@gmail.com>

As a Turk, I always approve of kebab-case.

FWIW,

Acked-by: Timur Tabi <ttabi@nvidia.com>

Re: [PATCH] gpu: nova: rename drivers to use kebab-case convention

[John Hubbard]

On 3/9/26 11:24 PM, Cheng-Yang Chou wrote:
> Rename nova-core driver from "NovaCore" to "nova-core" and nova-drm
> driver from "Nova" to "nova-drm" to follow kernel naming conventions
> before these names become UAPI (e.g. exposed via driver_override).
> 
> Link: https://github.com/Rust-for-Linux/linux/issues/1228
> Signed-off-by: Cheng-Yang Chou <yphbchou0911@gmail.com>
> ---
>  drivers/gpu/drm/nova/driver.rs     | 4 ++--
>  drivers/gpu/drm/nova/nova.rs       | 2 +-
>  drivers/gpu/nova-core/nova_core.rs | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/nova/driver.rs b/drivers/gpu/drm/nova/driver.rs
> index b1af0a099551..addf70c33cb2 100644
> --- a/drivers/gpu/drm/nova/driver.rs
> +++ b/drivers/gpu/drm/nova/driver.rs
> @@ -32,11 +32,11 @@ pub(crate) struct NovaData {
>      major: 0,
>      minor: 0,
>      patchlevel: 0,
> -    name: c"nova",
> +    name: c"nova-drm",
>      desc: c"Nvidia Graphics",

hmm, as long as we are fooling around with names here, I see that
this should be "NVIDIA Graphics and Compute", really.

Obviously that can be done separately, though.

>  };
>  
> -const NOVA_CORE_MODULE_NAME: &CStr = c"NovaCore";
> +const NOVA_CORE_MODULE_NAME: &CStr = c"nova-core";
>  const AUXILIARY_NAME: &CStr = c"nova-drm";
>  
>  kernel::auxiliary_device_table!(
> diff --git a/drivers/gpu/drm/nova/nova.rs b/drivers/gpu/drm/nova/nova.rs
> index 8893e58ee0db..1fd454c7e0df 100644
> --- a/drivers/gpu/drm/nova/nova.rs
> +++ b/drivers/gpu/drm/nova/nova.rs
> @@ -10,7 +10,7 @@
>  
>  kernel::module_auxiliary_driver! {
>      type: NovaDriver,
> -    name: "Nova",
> +    name: "nova-drm",

Well, but now it is out of sync with the file name: nova.rs.

You should change both, or neither, I'm thinking.

>      authors: ["Danilo Krummrich"],
>      description: "Nova GPU driver",
>      license: "GPL v2",
> diff --git a/drivers/gpu/nova-core/nova_core.rs b/drivers/gpu/nova-core/nova_core.rs
> index c1121e7c64c5..90e98380687b 100644
> --- a/drivers/gpu/nova-core/nova_core.rs
> +++ b/drivers/gpu/nova-core/nova_core.rs
> @@ -22,7 +22,7 @@
>  
>  kernel::module_pci_driver! {
>      type: driver::NovaCore,
> -    name: "NovaCore",
> +    name: "nova-core",

This bit looks good.

>      authors: ["Danilo Krummrich"],
>      description: "Nova Core GPU driver",
>      license: "GPL v2",

thanks,
-- 
John Hubbard

Claude review: gpu: nova: rename drivers to use kebab-case convention

[Claude Code Review Bot]

Overall Series Review

Subject: gpu: nova: rename drivers to use kebab-case convention
Author: Cheng-Yang Chou <yphbchou0911@gmail.com>
Patches: 3
Reviewed: 2026-03-11T13:37:58.845294

---

This is a single-patch series that renames the Nova GPU driver module names from CamelCase (`"NovaCore"`, `"Nova"`) to kebab-case (`"nova-core"`, `"nova-drm"`) to follow kernel naming conventions before these names become UAPI. The motivation is sound — the linked issue (Rust-for-Linux/linux#1228) tracks this naming convention concern, and it's better to fix this before UAPI exposure via `driver_override`.

The patch is small, focused, and the three changes are internally consistent. However, there are two issues worth discussing.

---
Generated by Claude Code Patch Reviewer

Claude review: gpu: nova: rename drivers to use kebab-case convention

[Claude Code Review Bot]

Patch Review

**Positive aspects:**
- The change is well-motivated — fixing naming before UAPI exposure is the right time.
- The three modified files are internally consistent: `NOVA_CORE_MODULE_NAME` in `driver.rs:39` is changed to `c"nova-core"`, which matches the `name: "nova-core"` in `nova_core.rs:25`. This is critical because `NOVA_CORE_MODULE_NAME` is used to construct the auxiliary device table entry at `driver.rs:47`:
  ```rust
  auxiliary::DeviceId::new(NOVA_CORE_MODULE_NAME, AUXILIARY_NAME),
  ```
  and must match the actual module name used when registering auxiliary devices at `driver.rs:92`:
  ```rust
  auxiliary::Registration::new(pdev.as_ref(), c"nova-drm", 0, crate::MODULE_NAME)
  ```
  where `MODULE_NAME` derives from the `name` field in `module_pci_driver!`.

**Issue 1: DRM driver `name` vs module `name` confusion**

The patch changes the DRM `DriverInfo::name` field from `"nova"` to `"nova-drm"`:
```rust
-    name: c"nova",
+    name: c"nova-drm",
```
This is the DRM driver name exposed to userspace via `/sys/class/drm/cardN/device/driver/name` and through the `DRM_IOCTL_VERSION` ioctl. This is a different concept from the kernel module name. The DRM driver name `"nova"` seems intentionally distinct from the module name — other DRM drivers don't append `-drm` to their DRM name (e.g., `amdgpu` the module name and `amdgpu` the DRM name, not `amdgpu-drm`). Changing this could break userspace tools that use the DRM driver name. The commit message doesn't discuss this change specifically, suggesting it may be unintentional conflation of the two different "name" concepts. This change should likely be dropped or explicitly justified.

**Issue 2: Module `name` in `module_auxiliary_driver!`**

The change from `"Nova"` to `"nova-drm"` in `nova.rs`:
```rust
-    name: "Nova",
+    name: "nova-drm",
```
This is the kernel module name for the nova DRM module. The actual `.ko` file is `nova.ko` (based on the Kconfig/Makefile naming `CONFIG_DRM_NOVA`). The `name` field in `module_*_driver!` macros in Rust maps to the `MODULE_NAME` / module metadata. Having the module name be `"nova-drm"` when the `.ko` is `nova.ko` could create confusion. It would be worth verifying whether this should be `"nova"` (matching the `.ko` filename) or `"nova-drm"` (matching the auxiliary device name), and confirming that the Kconfig/Makefile entries align. The convention for kernel modules is typically to match the `.ko` name.

**Summary:** The nova-core rename from `"NovaCore"` to `"nova-core"` is clearly correct. The nova-drm module name change is reasonable but the DRM `DriverInfo::name` change from `"nova"` to `"nova-drm"` looks wrong — this is a userspace-visible DRM driver name that should remain `"nova"`. The patch should be split or the DRM driver name change should be reverted.

---
Generated by Claude Code Patch Reviewer