public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
* [PATCH] drm: verisilicon: DRM_VERISILICON_DC should depend on ARCH_THEAD
@ 2026-02-26 11:00 Geert Uytterhoeven
  2026-02-26 15:36 ` Icenowy Zheng
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2026-02-26 11:00 UTC (permalink / raw)
  To: Icenowy Zheng, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann, David Airlie, Simona Vetter
  Cc: dri-devel, linux-kernel, Geert Uytterhoeven

Currently, the Verisilicon DC-series display controller driver supports
only the DC8200 variant in the T-HEAD TH1520 SoC.  Hence restrict the
dependency on RISCV to ARCH_THEAD, to prevent asking the user about this
driver when configuring a kernel without T-HEAD platform support.

The dependency can be relaxed later, when adding support for appropriate
SoCs from other vendors.

Fixes: dbf21777caa8b8c8 ("drm: verisilicon: add a driver for Verisilicon display controllers")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/gpu/drm/verisilicon/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/verisilicon/Kconfig b/drivers/gpu/drm/verisilicon/Kconfig
index 7cce86ec8603c596..f2edde9e0037ebcd 100644
--- a/drivers/gpu/drm/verisilicon/Kconfig
+++ b/drivers/gpu/drm/verisilicon/Kconfig
@@ -2,7 +2,7 @@
 config DRM_VERISILICON_DC
 	tristate "DRM Support for Verisilicon DC-series display controllers"
 	depends on DRM && COMMON_CLK
-	depends on RISCV || COMPILE_TEST
+	depends on ARCH_THEAD || COMPILE_TEST
 	select DRM_BRIDGE_CONNECTOR
 	select DRM_CLIENT_SELECTION
 	select DRM_DISPLAY_HELPER
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm: verisilicon: DRM_VERISILICON_DC should depend on ARCH_THEAD
  2026-02-26 11:00 [PATCH] drm: verisilicon: DRM_VERISILICON_DC should depend on ARCH_THEAD Geert Uytterhoeven
@ 2026-02-26 15:36 ` Icenowy Zheng
  2026-02-27  2:27 ` Claude review: " Claude Code Review Bot
  2026-02-27  2:27 ` Claude Code Review Bot
  2 siblings, 0 replies; 4+ messages in thread
From: Icenowy Zheng @ 2026-02-26 15:36 UTC (permalink / raw)
  To: Geert Uytterhoeven, Maarten Lankhorst, Maxime Ripard,
	Thomas Zimmermann, David Airlie, Simona Vetter
  Cc: dri-devel, linux-kernel, Michal Wilczynski

在 2026-02-26四的 12:00 +0100,Geert Uytterhoeven写道:
> Currently, the Verisilicon DC-series display controller driver
> supports
> only the DC8200 variant in the T-HEAD TH1520 SoC.  Hence restrict the
> dependency on RISCV to ARCH_THEAD, to prevent asking the user about
> this
> driver when configuring a kernel without T-HEAD platform support.
> 
> The dependency can be relaxed later, when adding support for
> appropriate
> SoCs from other vendors.

Michal Wilczynski has verified that this driver will work on StarFive
JH7110 with some extra glue drivers (but without modification to this
driver itself). [1]

Although this can be considered as future work and changing to
ARCH_THEAD seems okay now.

(BTW the hardware identification values is taken from the vendor driver
and it should support different variants of DC8200)

Thanks
Icenowy

[1]
https://lists.freedesktop.org/archives/dri-devel/2025-November/535442.html

> 
> Fixes: dbf21777caa8b8c8 ("drm: verisilicon: add a driver for
> Verisilicon display controllers")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/gpu/drm/verisilicon/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/verisilicon/Kconfig
> b/drivers/gpu/drm/verisilicon/Kconfig
> index 7cce86ec8603c596..f2edde9e0037ebcd 100644
> --- a/drivers/gpu/drm/verisilicon/Kconfig
> +++ b/drivers/gpu/drm/verisilicon/Kconfig
> @@ -2,7 +2,7 @@
>  config DRM_VERISILICON_DC
>  	tristate "DRM Support for Verisilicon DC-series display
> controllers"
>  	depends on DRM && COMMON_CLK
> -	depends on RISCV || COMPILE_TEST
> +	depends on ARCH_THEAD || COMPILE_TEST
>  	select DRM_BRIDGE_CONNECTOR
>  	select DRM_CLIENT_SELECTION
>  	select DRM_DISPLAY_HELPER


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Claude review: drm: verisilicon: DRM_VERISILICON_DC should depend on ARCH_THEAD
  2026-02-26 11:00 [PATCH] drm: verisilicon: DRM_VERISILICON_DC should depend on ARCH_THEAD Geert Uytterhoeven
  2026-02-26 15:36 ` Icenowy Zheng
  2026-02-27  2:27 ` Claude review: " Claude Code Review Bot
@ 2026-02-27  2:27 ` Claude Code Review Bot
  2 siblings, 0 replies; 4+ messages in thread
From: Claude Code Review Bot @ 2026-02-27  2:27 UTC (permalink / raw)
  To: dri-devel-reviews

Overall Series Review

Subject: drm: verisilicon: DRM_VERISILICON_DC should depend on ARCH_THEAD
Author: Geert Uytterhoeven <geert+renesas@glider.be>
Patches: 2
Reviewed: 2026-02-27T12:27:47.548832

---

This is a single, straightforward Kconfig dependency tightening patch from Geert Uytterhoeven. The change narrows the platform dependency for the Verisilicon DC display controller driver from the broad `RISCV` architecture to the specific `ARCH_THEAD` sub-platform, since the driver currently only supports the DC8200 variant found in the T-HEAD TH1520 SoC.

The patch is well-motivated and follows established kernel conventions. Multiple other T-HEAD-specific drivers in the tree already use the exact same `depends on ARCH_THEAD || COMPILE_TEST` pattern (e.g., `drivers/clk/thead/Kconfig`, `drivers/mailbox/Kconfig`, `drivers/pinctrl/Kconfig`, `drivers/reset/Kconfig`, `drivers/pwm/Kconfig`).

The patch could not be applied because the `drivers/gpu/drm/verisilicon/` directory does not yet exist in the drm-next tree — the base driver (`dbf21777caa8b8c8`) must be in a topic branch or another tree that hasn't been merged yet.

**Verdict:** The patch looks correct and ready to apply (once its prerequisite lands).

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Claude review: drm: verisilicon: DRM_VERISILICON_DC should depend on ARCH_THEAD
  2026-02-26 11:00 [PATCH] drm: verisilicon: DRM_VERISILICON_DC should depend on ARCH_THEAD Geert Uytterhoeven
  2026-02-26 15:36 ` Icenowy Zheng
@ 2026-02-27  2:27 ` Claude Code Review Bot
  2026-02-27  2:27 ` Claude Code Review Bot
  2 siblings, 0 replies; 4+ messages in thread
From: Claude Code Review Bot @ 2026-02-27  2:27 UTC (permalink / raw)
  To: dri-devel-reviews

Patch Review

**Commit message:** Clear and well-written. Correctly explains the rationale (driver only supports DC8200 in TH1520), notes the Fixes tag, and mentions that the dependency can be relaxed later.

**Code change:**

```diff
-	depends on RISCV || COMPILE_TEST
+	depends on ARCH_THEAD || COMPILE_TEST
```

This is correct. `ARCH_THEAD` is defined under `arch/riscv/Kconfig.socs` and already implies `RISCV`, so the architecture constraint is preserved while being more specific. The `COMPILE_TEST` alternative is properly kept so build-testing coverage is not lost.

The pattern matches what other T-HEAD peripheral drivers use throughout the tree. For example, `drivers/firmware/Kconfig:216` and `drivers/clk/thead/Kconfig:5` both have the identical `depends on ARCH_THEAD || COMPILE_TEST` construct.

**Fixes tag:** References `dbf21777caa8b8c8 ("drm: verisilicon: add a driver for Verisilicon display controllers")` which is appropriate — this is the commit that introduced the overly broad dependency.

**No issues found.** 

Reviewed-by worthy as-is.

---
Generated by Claude Code Patch Reviewer

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-02-27  2:27 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-26 11:00 [PATCH] drm: verisilicon: DRM_VERISILICON_DC should depend on ARCH_THEAD Geert Uytterhoeven
2026-02-26 15:36 ` Icenowy Zheng
2026-02-27  2:27 ` Claude review: " Claude Code Review Bot
2026-02-27  2:27 ` Claude Code Review Bot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox