From: Marek Vasut <marek.vasut@mailbox.org>
To: Ethan Tidmore <ethantidmore06@gmail.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Cc: Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Marek Vasut <marek.vasut+renesas@mailbox.org>,
Joseph Guo <qijian.guo@nxp.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] drm/bridge: waveshare-dsi: Fix signedness bug
Date: Sat, 7 Mar 2026 04:44:10 +0100 [thread overview]
Message-ID: <fe3c0b16-1d29-4bca-bff3-15217f9b73f7@mailbox.org> (raw)
In-Reply-To: <20260307033245.71666-1-ethantidmore06@gmail.com>
On 3/7/26 4:32 AM, Ethan Tidmore wrote:
> The function drm_of_get_data_lanes_count_ep() returns negative error
> codes and dsi->lanes is an unsigned integer, so the check (dsi->lanes <
> 0) is always impossible.
>
> Make the return value of drm_of_get_data_lanes_count_ep() be assigned to
> ret, check for error, and then assign dsi->lanes to ret.
>
> Detected by Smatch:
> drivers/gpu/drm/bridge/waveshare-dsi.c:70 ws_bridge_attach_dsi() warn:
> unsigned 'dsi->lanes' is never less than zero.
I already sent:
[PATCH] drm/bridge: waveshare-dsi: Use temporary signed variable for DSI
lanes validation
next prev parent reply other threads:[~2026-03-07 3:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-07 3:32 [PATCH] drm/bridge: waveshare-dsi: Fix signedness bug Ethan Tidmore
2026-03-07 3:44 ` Marek Vasut [this message]
2026-03-07 6:42 ` Ethan Tidmore
2026-03-07 15:57 ` Marek Vasut
2026-03-08 22:10 ` Claude review: " Claude Code Review Bot
2026-03-08 22:10 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe3c0b16-1d29-4bca-bff3-15217f9b73f7@mailbox.org \
--to=marek.vasut@mailbox.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ethantidmore06@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=luca.ceresoli@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marek.vasut+renesas@mailbox.org \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=qijian.guo@nxp.com \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox