public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: cristian_ci <cristian_ci@protonmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
	Jessica Zhang <jesszhan0024@gmail.com>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	~postmarketos/upstreaming@lists.sr.ht,
	phone-devel@vger.kernel.org
Subject: Re: [PATCH v2 1/6] dt-bindings: display: panel: Add Novatek NT35532 LCD DSI
Date: Fri, 20 Mar 2026 22:32:18 +0000	[thread overview]
Message-ID: <oMTrCB7euJojLz1EUHDhHCq071GQWD0g7-sqwahA62CnM-sVw08UCNhKdgHX2NrEN3H8iRhc0suejuq5JZ39UA2nEfKhRq9qwYJWSxCrAtc=@protonmail.com> (raw)
In-Reply-To: <20260319-amorphous-pastoral-turtle-851af9@quoll>

On Thursday, March 19th, 2026 at 10:09, Krzysztof Kozlowski <krzk@kernel.org> wrote:

> On Wed, Mar 18, 2026 at 11:28:09PM +0100, Cristian Cozzolino wrote:
> > +  avdd-supply:
> > +    description: positive boost supply regulator
> > +
> > +  avee-supply:
> > +    description: negative boost supply regulator
> > +
> > +  vci-supply:
> > +    description: regulator that supplies the analog voltage
> > +
> > +  vddam-supply:
> > +    description: power supply for MIPI interface
> > +
> > +  vddi-supply:
> > +    description: regulator that supplies the I/O voltage
> > +
> > +  port: true
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - reset-gpios
> > +  - avdd-supply
> > +  - avee-supply
> > +  - vci-supply
> 
> Only VDDI is required according to datasheet (see page 11 and page 16).

Just to be sure, are you mentioning the part saying there are multiple 
power modes (2-1PWR, 2-2PWR, 3éWR and 4PWR) related to NT35532? 

> Others are needed only in specific configurations, which I would ignore
> for the simplicity of the binding. Drop these three.
> 
> Previous discussion point was about this - write bindings based on
> datasheet, since it is available.

I've removed avdd, avee and vci supplies from 'required' properties 
and I've also tested the new bindings (just for completeness). Now, 
I'm going to reintroduce again the issue already raised previously 
(for which I received no replies in v1): should I submit a v3 
series including my new changes or I've to stick with v2 here, in 
order to address review concerns about binding, first?

> > +  - vddi-supply
> > +  - port
> > +
> > +additionalProperties: false
> 
> Best regards,
> Krzysztof
> 
>

  reply	other threads:[~2026-03-20 22:32 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-18 22:28 [PATCH v2 0/6] Enable new features for flipkart-rimob Cristian Cozzolino via B4 Relay
2026-03-18 22:28 ` [PATCH v2 1/6] dt-bindings: display: panel: Add Novatek NT35532 LCD DSI Cristian Cozzolino via B4 Relay
2026-03-19  9:09   ` Krzysztof Kozlowski
2026-03-20 22:32     ` cristian_ci [this message]
2026-03-21  9:56       ` Krzysztof Kozlowski
2026-03-21 16:15         ` cristian_ci
2026-03-21 19:00   ` Claude review: " Claude Code Review Bot
2026-03-18 22:28 ` [PATCH v2 2/6] drm/panel: Add driver for Novatek NT35532 Cristian Cozzolino via B4 Relay
2026-03-19  2:27   ` Dmitry Baryshkov
2026-03-20  7:19     ` cristian_ci
2026-03-20  7:39       ` Dmitry Baryshkov
2026-03-21 19:00   ` Claude review: " Claude Code Review Bot
2026-03-18 22:28 ` [PATCH v2 3/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable display and GPU Cristian Cozzolino via B4 Relay
2026-03-19  2:54   ` Dmitry Baryshkov
2026-03-21 19:00   ` Claude review: " Claude Code Review Bot
2026-03-18 22:28 ` [PATCH v2 4/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable WiFi/Bluetooth Cristian Cozzolino via B4 Relay
2026-03-21 19:00   ` Claude review: " Claude Code Review Bot
2026-03-18 22:28 ` [PATCH v2 5/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable touchscreen Cristian Cozzolino via B4 Relay
2026-03-19 10:42   ` Konrad Dybcio
2026-03-21 19:00   ` Claude review: " Claude Code Review Bot
2026-03-18 22:28 ` [PATCH v2 6/6] arm64: dts: qcom: msm8953-flipkart-rimob: Enable Hall sensor Cristian Cozzolino via B4 Relay
2026-03-19 10:43   ` Konrad Dybcio
2026-03-21 19:00   ` Claude review: " Claude Code Review Bot
2026-03-21 19:00 ` Claude review: Enable new features for flipkart-rimob Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='oMTrCB7euJojLz1EUHDhHCq071GQWD0g7-sqwahA62CnM-sVw08UCNhKdgHX2NrEN3H8iRhc0suejuq5JZ39UA2nEfKhRq9qwYJWSxCrAtc=@protonmail.com' \
    --to=cristian_ci@protonmail.com \
    --cc=airlied@gmail.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox