Claude review: Replace the dmabuf custom test framework with kunit

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: Replace the dmabuf custom test framework with kunit
Author: Jason Gunthorpe <jgg@nvidia.com>
Patches: 9
Reviewed: 2026-03-03T13:50:31.749534

---

This is a well-executed, mechanical conversion of the dma-buf self-test framework from a custom module_init-based test harness to kunit. The series is cleanly structured: patches 1-4 each migrate one test file from the old framework to kunit (moving it from the `dmabuf_selftests` module to `dmabuf_kunit`), and patch 5 removes the now-empty old framework.

The conversion patterns described in the cover letter are applied consistently throughout: `KUNIT_ASSERT_NOT_NULL` for fatal allocation failures, `KUNIT_FAIL` + goto for errors needing cleanup, and `KUNIT_EXPECT_EQ` for final result checks. The use of `KUNIT_ARRAY_PARAM_DESC` for the `dma_resv_usage` parameterization in patch 1 is a good fit. The `kunit_skip` for the multi-CPU race test in patch 2 is the right approach.

Multiple `kunit_test_suite()` calls across the constituent .o files work correctly because the macro uses `__UNIQUE_ID` and linker section placement rather than `module_init()`.

Overall the series is in good shape and I only found minor issues. No functional bugs were identified.

**Issues found (all minor):**
- One typo introduced in patch 2 ("on HZ" should be "one HZ")
- One stray trailing `\n` in a KUNIT_FAIL message in patch 1
- Some dead code (`r = -EINVAL` assignments) left inconsistently across cleanup paths
- Unnecessary `suite_init` in patch 2

---
Generated by Claude Code Patch Reviewer