Claude review: Re: [PATCH] drm/amdgpu: fix PASID task_info lookup race

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: Re: [PATCH] drm/amdgpu: fix PASID task_info lookup race
Author: =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Patches: 2
Reviewed: 2026-03-11T13:51:08.979104

---

This is a single-patch fix for a real use-after-free race condition in `amdgpu_vm_get_task_info_pasid()`. The race is between the PASID lookup path and `amdgpu_vm_fini()`:

1. Thread A calls `amdgpu_vm_get_vm_from_pasid()`, gets a pointer to the VM, releases the xarray lock.
2. Thread B runs `amdgpu_vm_fini()`, calls `xa_erase_irq()` to remove the PASID mapping, then eventually calls `amdgpu_vm_put_task_info()` which may free `task_info`.
3. Thread A dereferences `vm->task_info` — use-after-free.

The fix correctly collapses the lookup and reference acquisition into a single critical section under the xarray lock. The approach is sound and well-motivated.

**Verdict: The patch is correct and should be accepted, with minor observations below.**

---
Generated by Claude Code Patch Reviewer