From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Re: [PATCH] drm/xe/bo: Cache vram_region_gpu_offset in struct xe_bo
Date: Tue, 31 Mar 2026 17:42:00 +1000 [thread overview]
Message-ID: <review-overall-10289571cccff20ba52f224080754705c606ccfe.camel@linux.intel.com> (raw)
In-Reply-To: <10289571cccff20ba52f224080754705c606ccfe.camel@linux.intel.com>
Overall Series Review
Subject: Re: [PATCH] drm/xe/bo: Cache vram_region_gpu_offset in struct xe_bo
Author: Thomas =?ISO-8859-1?Q?Hellstr=F6m?= <thomas.hellstrom@linux.intel.com>
Patches: 2
Reviewed: 2026-03-31T17:42:00.027068
---
This is a single-patch optimization that caches the `vram_region_gpu_offset()` result in `struct xe_bo` to avoid repeated pointer chasing through TTM resource manager structures on every call, addressing an existing XXX comment in the code. The approach is sound and the patch is well-structured with a clear commit message, good caller analysis, and a KUnit test. However, there are a few correctness concerns around missed cache update paths.
**Verdict:** Good idea, mostly correct implementation, but has gaps in cache consistency that need to be addressed before merging.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-03-31 7:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-29 22:22 [PATCH] drm/xe/bo: Cache vram_region_gpu_offset in struct xe_bo Yuri Martins
2026-03-30 8:02 ` Thomas Hellström
2026-03-31 7:42 ` Claude review: " Claude Code Review Bot
2026-03-31 7:42 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-10289571cccff20ba52f224080754705c606ccfe.camel@linux.intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox