From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Re: [PATCH] accel/amdxdna: fix missing newline in pr_err message
Date: Sun, 22 Mar 2026 03:46:13 +1000 [thread overview]
Message-ID: <review-overall-1af543d3-46ff-7a9c-6432-fe3c9050e23d@amd.com> (raw)
In-Reply-To: <1af543d3-46ff-7a9c-6432-fe3c9050e23d@amd.com>
Overall Series Review
Subject: Re: [PATCH] accel/amdxdna: fix missing newline in pr_err message
Author: Lizhi Hou <lizhi.hou@amd.com>
Patches: 2
Reviewed: 2026-03-22T03:46:13.307891
---
This is a single-patch series that adds a missing `\n` newline character to a `pr_err()` call in the amdxdna mailbox driver. The fix is correct — `pr_err()` requires an explicit newline, unlike `dev_err()` which appends one automatically. Without the `\n`, the message will run into subsequent kernel log output.
The patch is trivial and correct. The only minor nit is the commit author name — "haoyu.lu" with a lowercase first name and dot separator is unconventional for a Signed-off-by; a real name like "Haoyu Lu" (as used in the From header) would be more appropriate.
The patch failed to apply likely because the drm-next tree has already changed the surrounding context in `amdxdna_mailbox.c` (the line is at 502 in drm-next vs 501 in the patch context).
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-03-21 17:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-20 11:29 [PATCH] accel/amdxdna: fix missing newline in pr_err message Haoyu Lu
2026-03-20 15:54 ` Lizhi Hou
2026-03-21 17:46 ` Claude review: " Claude Code Review Bot
2026-03-21 17:46 ` Claude Code Review Bot [this message]
2026-03-23 3:49 ` [PATCH v2] " Haoyu Lu
2026-03-23 16:40 ` Lizhi Hou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-1af543d3-46ff-7a9c-6432-fe3c9050e23d@amd.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox