From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Re: [PATCH] accel/amdxdna: fix missing newline in pr_err message Date: Sun, 22 Mar 2026 03:46:13 +1000 Message-ID: In-Reply-To: <1af543d3-46ff-7a9c-6432-fe3c9050e23d@amd.com> References: <1af543d3-46ff-7a9c-6432-fe3c9050e23d@amd.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Re: [PATCH] accel/amdxdna: fix missing newline in pr_err message Author: Lizhi Hou Patches: 2 Reviewed: 2026-03-22T03:46:13.307891 --- This is a single-patch series that adds a missing `\n` newline character to= a `pr_err()` call in the amdxdna mailbox driver. The fix is correct =E2=80= =94 `pr_err()` requires an explicit newline, unlike `dev_err()` which appen= ds one automatically. Without the `\n`, the message will run into subsequen= t kernel log output. The patch is trivial and correct. The only minor nit is the commit author n= ame =E2=80=94 "haoyu.lu" with a lowercase first name and dot separator is u= nconventional for a Signed-off-by; a real name like "Haoyu Lu" (as used in = the From header) would be more appropriate. The patch failed to apply likely because the drm-next tree has already chan= ged the surrounding context in `amdxdna_mailbox.c` (the line is at 502 in d= rm-next vs 501 in the patch context). --- Generated by Claude Code Patch Reviewer