From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/i915/guc: fix corrupted copyright symbols in selftest files Date: Wed, 11 Feb 2026 17:00:04 +1000 Message-ID: In-Reply-To: <20260209112709.2551603-1-khorenko@virtuozzo.com> References: <20260209112709.2551603-1-khorenko@virtuozzo.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Mailer: Claude Code Patch Reviewer Overall Series Review Subject: drm/i915/guc: fix corrupted copyright symbols in selftest files Author: Konstantin Khorenko Patches: 1 Reviewed: 2026-02-11T17:00:04.900261 --- This is a single-patch series that addresses a cosmetic issue in copyright headers. The patch fixes corrupted UTF-8 copyright symbols (©) that were rendered as Unicode replacement characters in two i915 GuC selftest files. **Scope**: Documentation/cosmetic fix only - no functional changes **Risk Level**: Minimal - only modifies copyright header comments **Testing Required**: None (comment-only changes) The patch is straightforward and appropriate. However, there are some considerations: 1. **Completeness**: The patch only fixes 2 files. A broader audit may be warranted to check if other files in the i915 driver (or kernel-wide) have the same corruption. 2. **Root Cause**: The commit message doesn't explain how these became corrupted or whether this is a systematic issue that could recur. 3. **Alternative Approach**: Some kernel subsystems prefer ASCII-only copyright headers using "(C)" instead of "©" to avoid encoding issues entirely. This might be worth discussing with maintainers. **Recommendation**: The patch itself is fine and can be merged, but consider: - Checking for similar issues in other i915 files - Documenting whether UTF-8 copyright symbols are preferred over ASCII equivalents in i915 --- Generated by Claude Code Patch Reviewer