From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: gpu: host1x: Fix passing zero to ERR_PTR in host1x_iommu_attach() Date: Wed, 11 Feb 2026 17:05:33 +1000 Message-ID: In-Reply-To: <20260209131426.37611-1-alperyasinak1@gmail.com> References: <20260209131426.37611-1-alperyasinak1@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Mailer: Claude Code Patch Reviewer Overall Series Review Subject: gpu: host1x: Fix passing zero to ERR_PTR in host1x_iommu_attach() Author: Alper Ak Patches: 1 Reviewed: 2026-02-11T17:05:33.927031 --- This is a single patch submission that addresses an error handling bug in the host1x IOMMU attachment code. The patch fixes a violation of the ERR_PTR/IS_ERR contract where ERR_PTR(0) could be returned, which evaluates to NULL and breaks the error handling convention in kernel code. **Series Assessment:** - **Scope**: Appropriately focused on a single bug fix - **Target**: Correctly marked for stable backport (Cc: stable@vger.kernel.org) - **Static Analysis Finding**: Identified by Smatch, which is a legitimate source for such bugs - **Fix Quality**: The fix needs careful examination of the broader error handling semantics **Key Concerns:** 1. The fix changes error handling semantics in a subtle way that requires validation 2. Need to verify all callers handle both NULL and ERR_PTR return values correctly 3. The original code path's intention when setting err=0 needs clarification --- --- Generated by Claude Code Patch Reviewer