public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/rockchip: vop2: Use drm_err_ratelimited() for wait timeouts
Date: Wed, 11 Feb 2026 16:54:13 +1000	[thread overview]
Message-ID: <review-overall-20260209161621.6136-1-hungen3108@gmail.com> (raw)
In-Reply-To: <20260209161621.6136-1-hungen3108@gmail.com>

Overall Series Review

Subject: drm/rockchip: vop2: Use drm_err_ratelimited() for wait
 timeouts
Author: Hsieh Hung-En <hungen3108@gmail.com>
Patches: 1
Reviewed: 2026-02-11T16:54:13.232428

---

This single-patch series updates error logging in the Rockchip VOP2 driver by replacing the deprecated `DRM_DEV_ERROR()` macro with `drm_err_ratelimited()`. The change is straightforward and addresses two timeout error messages in register polling functions.

**Scope**: The patch touches only error logging paths in two wait-for-done functions in `rockchip_vop2_reg.c`.

**Correctness**: The conversion appears correct but has a subtle behavioral change that should be acknowledged - rate limiting is now applied where it wasn't before.

**Rationale**: Modernizing to current DRM logging APIs and preventing log spam from repeated timeouts is reasonable.

**Concerns**:
1. The commit message claims this prevents "flooding the kernel log when timeouts repeat" - but the original `DRM_DEV_ERROR()` was NOT rate-limited, so this introduces new behavior that should be discussed
2. Missing analysis of whether rate-limiting timeout errors is actually desirable in this specific context
3. The conversion changes the first parameter from `vop2->dev` to `vop2->drm` - this changes the log device context

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-02-11  6:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-09 16:16 [PATCH] drm/rockchip: vop2: Use drm_err_ratelimited() for wait timeouts Hsieh Hung-En
2026-02-11  6:54 ` Claude review: " Claude Code Review Bot
2026-02-11  6:54 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260209161621.6136-1-hungen3108@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox