From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/rockchip: vop2: Use drm_err_ratelimited() for wait timeouts Date: Wed, 11 Feb 2026 16:54:13 +1000 Message-ID: In-Reply-To: <20260209161621.6136-1-hungen3108@gmail.com> References: <20260209161621.6136-1-hungen3108@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Mailer: Claude Code Patch Reviewer Overall Series Review Subject: drm/rockchip: vop2: Use drm_err_ratelimited() for wait timeouts Author: Hsieh Hung-En Patches: 1 Reviewed: 2026-02-11T16:54:13.232428 --- This single-patch series updates error logging in the Rockchip VOP2 driver by replacing the deprecated `DRM_DEV_ERROR()` macro with `drm_err_ratelimited()`. The change is straightforward and addresses two timeout error messages in register polling functions. **Scope**: The patch touches only error logging paths in two wait-for-done functions in `rockchip_vop2_reg.c`. **Correctness**: The conversion appears correct but has a subtle behavioral change that should be acknowledged - rate limiting is now applied where it wasn't before. **Rationale**: Modernizing to current DRM logging APIs and preventing log spam from repeated timeouts is reasonable. **Concerns**: 1. The commit message claims this prevents "flooding the kernel log when timeouts repeat" - but the original `DRM_DEV_ERROR()` was NOT rate-limited, so this introduces new behavior that should be discussed 2. Missing analysis of whether rate-limiting timeout errors is actually desirable in this specific context 3. The conversion changes the first parameter from `vop2->dev` to `vop2->drm` - this changes the log device context --- Generated by Claude Code Patch Reviewer