Claude review: drm/msm: always recover the gpu

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/msm: always recover the gpu
Author: Anna Maniscalco <anna.maniscalco2000@gmail.com>
Patches: 1
Reviewed: 2026-02-11T16:22:11.633679

---

This is a single-patch series addressing a GPU recovery bug in the MSM DRM driver. The patch removes a conditional check (`if (msm_gpu_active(gpu))`) that was preventing GPU recovery from executing when the GPU appeared idle after a hang.

**Summary:**
- **Problem identified:** The recover_worker could skip recovery if the GPU appeared idle after incrementing fences, creating a state where the GPU remains hung
- **Solution approach:** Remove the `msm_gpu_active()` check to ensure recovery always executes
- **Risk assessment:** Medium - changes critical error recovery path
- **Testing concerns:** Needs validation across suspend/resume cycles and various workload scenarios

**Key concerns:**
1. The patch removes a power management optimization but doesn't explain all implications
2. Missing analysis of why `msm_gpu_active()` check was originally added
3. Needs testing evidence to support the claim about GPU state persistence
4. Power consumption impact not addressed

---
Generated by Claude Code Patch Reviewer