From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/msm: always recover the gpu Date: Wed, 11 Feb 2026 16:22:11 +1000 Message-ID: In-Reply-To: <20260210-recovery_suspend_fix-v1-1-00ed9013da04@gmail.com> References: <20260210-recovery_suspend_fix-v1-1-00ed9013da04@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Mailer: Claude Code Patch Reviewer Overall Series Review Subject: drm/msm: always recover the gpu Author: Anna Maniscalco Patches: 1 Reviewed: 2026-02-11T16:22:11.633679 --- This is a single-patch series addressing a GPU recovery bug in the MSM DRM driver. The patch removes a conditional check (`if (msm_gpu_active(gpu))`) that was preventing GPU recovery from executing when the GPU appeared idle after a hang. **Summary:** - **Problem identified:** The recover_worker could skip recovery if the GPU appeared idle after incrementing fences, creating a state where the GPU remains hung - **Solution approach:** Remove the `msm_gpu_active()` check to ensure recovery always executes - **Risk assessment:** Medium - changes critical error recovery path - **Testing concerns:** Needs validation across suspend/resume cycles and various workload scenarios **Key concerns:** 1. The patch removes a power management optimization but doesn't explain all implications 2. Missing analysis of why `msm_gpu_active()` check was originally added 3. Needs testing evidence to support the claim about GPU state persistence 4. Power consumption impact not addressed --- Generated by Claude Code Patch Reviewer