Claude review: Support for the Pixel 3a XL with the Tianma panel

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: Support for the Pixel 3a XL with the Tianma panel
Author: Richard Acayan <mailingradian@gmail.com>
Patches: 10
Reviewed: 2026-02-11T16:47:57.512044

---

This 6-patch series adds support for the Google Pixel 3a XL (Bonito) with the Tianma/Novatek NT37700F AMOLED panel to the Linux kernel. The series refactors existing Pixel 3a (Sargo) device trees into a common include file, adds a new panel driver, and creates device-specific configurations.

**HIGH-LEVEL ASSESSMENT:**

**CRITICAL ISSUES:**
1. **Wrong binding file** - Patch 2 adds NT37700F to panel-simple-dsi.yaml, but Patch 3 implements a full custom driver with vendor-specific commands, not a simple-dsi panel. Needs dedicated binding documentation.
2. **Commit message error** - Patch 1 describes "bonito-sdc" but adds "bonito-tianma" compatible string
3. **TODO in production code** - Panel driver contains unresolved TODO comment that must be removed
4. **License change** - Patch 5 changes from GPL-2.0 to GPL-2.0-only without explanation
5. **Compatible string issue** - Should be vendor-specific "tianma,nt37700f" not generic "novatek,nt37700f"

**MAJOR ISSUES:**
1. Missing base "google,bonito" compatible documentation
2. Touchscreen dimension change (62mm→63mm) buried in refactoring without explanation
3. Copyright years (2023-2024) don't match submission date (2026)
4. Module description says "cmd mode" but driver uses video mode
5. C++ style comments in device tree files

**POSITIVE ASPECTS:**
- Clean driver implementation using modern kernel APIs (mipi_dsi_multi_context)
- Logical device tree refactoring approach
- Proper error handling in most paths
- Good use of DRM panel helper functions

**OVERALL RECOMMENDATION:** **NACK** - Series requires significant revision before merging.

---

---
Generated by Claude Code Patch Reviewer