From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/tyr: gpu: fix GpuInfo::log model/version decoding Date: Wed, 11 Feb 2026 16:17:51 +1000 Message-ID: In-Reply-To: <20260210183812.261142-1-work@onurozkan.dev> References: <20260210183812.261142-1-work@onurozkan.dev> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Mailer: Claude Code Patch Reviewer Overall Series Review Subject: drm/tyr: gpu: fix GpuInfo::log model/version decoding Author: =?UTF-8?q?Onur=20=C3=96zkan?= Patches: 1 Reviewed: 2026-02-11T16:17:51.416707 --- This is a single-patch series that fixes GPU model detection in the DRM Tyr driver (a Rust-based Mali GPU driver). The patch addresses a fundamental bug where GPU_ID register bits were being incorrectly decoded, leading to wrong model identification ("mali-unknown" instead of "mali-g610" on RK3588S). **Strengths:** - Fixes a real bug with clear before/after evidence from hardware testing - Improves code clarity by using existing GpuId::from() helper instead of manual bit manipulation - Renames struct fields to accurately reflect their semantic meaning (arch_major/prod_major vs major/minor) - Tested on real hardware (Orange Pi 5 with RK3588S) **Concerns:** - The commit message could better explain the Mali GPU_ID register layout - Missing information about what GpuId::from() actually does and where it's defined - Unclear if GPU_MODELS array needs expansion for other Mali GPUs - The debug output still shows "major 0x0 minor 0x0" which might be confusing --- Generated by Claude Code Patch Reviewer