From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/buddy: Documentation and internal helper cleanup Date: Wed, 11 Feb 2026 16:07:51 +1000 Message-ID: In-Reply-To: <20260211053123.260037-4-sanjay.kumar.yadav@intel.com> References: <20260211053123.260037-4-sanjay.kumar.yadav@intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Mailer: Claude Code Patch Reviewer Overall Series Review Subject: drm/buddy: Documentation and internal helper cleanup Author: Sanjay Yadav Patches: 3 Reviewed: 2026-02-11T16:07:51.694362 --- This v2 patch series improves the GPU buddy allocator by adding comprehensive kernel-doc documentation and cleaning up the internal API surface. The series addresses feedback from v1, including correcting documentation for tree index values and adapting to the recent code relocation to `drivers/gpu/`. **Series Structure:** The two-patch split is logical - documentation additions first, followed by code cleanup. This ordering makes sense as it documents the API before narrowing it. **Scope:** The series claims "No functional changes" which appears accurate. The changes are purely documentation and code organization improvements. **Version Changes:** The v2 changelog indicates: - Rebase after DRM buddy allocator moved to `drivers/gpu/` - Retained `gpu_buddy_block_is_free()` in header (now used by `drm_buddy.c`) - Fixed tree index documentation (responding to Arun's feedback) **Review Status:** Patch 2/2 already has `Reviewed-by: Arunpravin Paneer Selvam`. **Concerns:** 1. The series references `drm_buddy.c` using `gpu_buddy_block_is_free()`, but this file isn't shown in the diff context. Need to verify this external dependency. 2. The header bit layout documentation in Patch 1 should be verified against actual usage. --- --- Generated by Claude Code Patch Reviewer