Claude review: Power Management for Raspberry Pi V3D GPU

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: Power Management for Raspberry Pi V3D GPU
Author: =?utf-8?q?Ma=C3=ADra_Canal?= <mcanal@igalia.com>
Patches: 8
Reviewed: 2026-02-14T07:21:52.077935

---

This series introduces runtime power management for the Raspberry Pi V3D GPU driver, allowing the V3D clock to be disabled during idle periods. The work is split across three subsystems: clock framework changes to give V3D consumers control over clock rates (patches 1-3), a timeout increase for the BCM2835 ASB power domain controller (patch 4), and the V3D driver changes to reorder probe, separate HW init from resource allocation, and implement runtime PM callbacks (patches 5-7).

The architectural approach is sound: patch 6 carefully separates resource allocation (which does not need the GPU powered) from hardware initialization (which does), making the subsequent introduction of runtime PM callbacks in patch 7 clean. The runtime PM integration wraps all hardware-accessing paths -- ioctls, debugfs, job submission, MMU flushing, perfmon, and GPU reset -- with appropriate get/put calls.

There are a few issues worth discussing, primarily around the error cleanup ordering in patch 6's probe function and a missing `v3d_init_hw_state` call in the resume path. The `!CONFIG_PM` handling also has a minor gap. These are detailed in the per-patch reviews below.

---
Generated by Claude Code Patch Reviewer