From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Power Management for Raspberry Pi V3D GPU Date: Sat, 14 Feb 2026 07:21:52 +1000 Message-ID: In-Reply-To: <20260213-v3d-power-management-v5-0-7a8b381eb379@igalia.com> References: <20260213-v3d-power-management-v5-0-7a8b381eb379@igalia.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Power Management for Raspberry Pi V3D GPU Author: =3D?utf-8?q?Ma=3DC3=3DADra_Canal?=3D Patches: 8 Reviewed: 2026-02-14T07:21:52.077935 --- This series introduces runtime power management for the Raspberry Pi V3D GPU = driver, allowing the V3D clock to be disabled during idle periods. The work i= s split across three subsystems: clock framework changes to give V3D consumer= s control over clock rates (patches 1-3), a timeout increase for the BCM2835 = ASB power domain controller (patch 4), and the V3D driver changes to reorder = probe, separate HW init from resource allocation, and implement runtime PM ca= llbacks (patches 5-7). The architectural approach is sound: patch 6 carefully separates resource all= ocation (which does not need the GPU powered) from hardware initialization (w= hich does), making the subsequent introduction of runtime PM callbacks in pat= ch 7 clean. The runtime PM integration wraps all hardware-accessing paths -- = ioctls, debugfs, job submission, MMU flushing, perfmon, and GPU reset -- with= appropriate get/put calls. There are a few issues worth discussing, primarily around the error cleanup o= rdering in patch 6's probe function and a missing `v3d_init_hw_state` call in= the resume path. The `!CONFIG_PM` handling also has a minor gap. These are d= etailed in the per-patch reviews below. --- Generated by Claude Code Patch Reviewer