From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Revert "drm/msm/dpu: try reserving the DSPP-less LM first"
Date: Sat, 14 Feb 2026 13:59:51 +1000 [thread overview]
Message-ID: <review-overall-20260214-revert-dspp-less-v1-1-be0d636a2a6e@oss.qualcomm.com> (raw)
In-Reply-To: <20260214-revert-dspp-less-v1-1-be0d636a2a6e@oss.qualcomm.com>
Overall Series Review
Subject: Revert "drm/msm/dpu: try reserving the DSPP-less LM first"
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patches: 1
Reviewed: 2026-02-14T13:59:51.835481
---
This is a single-patch revert of commit 42f62cd79578 ("drm/msm/dpu: try reserving the DSPP-less LM first"), which introduced an optimization to prefer layer mixers (LMs) without DSPPs when DSPPs weren't needed by the topology. The revert is motivated by reports of blue screens on Hamoa (X1E80100) laptops, indicating that the optimization exposed a hardware dependency or initialization issue with higher-numbered LMs on newer DPU generations.
The revert is clean and straightforward. It removes the `dpu_rm_find_lms()` helper function and inlines the mixer search loop back into `_dpu_rm_reserve_lms()`, removing the `skip_dspp` parameter and the two-pass search strategy. The resulting code matches what the pre-optimization code looked like, restoring the simple linear scan of mixer blocks.
No significant issues found. The patch is a correct revert addressing a real regression.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-14 3:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-13 23:02 [PATCH] Revert "drm/msm/dpu: try reserving the DSPP-less LM first" Dmitry Baryshkov
2026-02-14 3:59 ` Claude Code Review Bot [this message]
2026-02-14 3:59 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260214-revert-dspp-less-v1-1-be0d636a2a6e@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox