Claude review: drm: bridge: anx7625: don't crash if Type-C port is not used

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm: bridge: anx7625: don't crash if Type-C port is not used
Author: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patches: 1
Reviewed: 2026-02-15T19:02:41.103070

---

This is a single-patch fix for a NULL pointer dereference crash in the anx7625 DRM bridge driver's Type-C support code. The crash occurs when CONFIG_TYPEC is enabled but the anx7625 device tree node does not include a USB-C connector fwnode, leaving `ctx->typec_port` as NULL. The `typec_set_*()` family of functions do not handle NULL port arguments, so calling them unconditionally causes a kernel crash.

The fix is minimal and appropriate: a NULL check on `ctx->typec_port` at the top of `anx7625_typec_set_status()`, which is the single chokepoint through which all typec state updates flow. The commit message includes the actual crash trace, a clear Fixes: tag, and proper attribution. The approach is correct — guarding at the entry point rather than at each individual `typec_set_*()` call site keeps the fix simple and complete.

One minor observation: the original submitter's changelog mentioned a dropped chunk for `anx7625_typec_unregister()`. Since `typec_unregister_port()` also does not tolerate NULL, that path could have a similar issue if the unregister path is reached without a typec port having been registered. However, the note "[db: dropped chunk anx7625_typec_unregister()]" suggests this was considered and determined unnecessary — likely because `typec_unregister_port(NULL)` is either already guarded or the unregister path isn't reachable without a successful registration. Without the tree containing this code I cannot verify, but it's worth the author confirming.

---
Generated by Claude Code Patch Reviewer