public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: media: videobuf2: Set vma_flags in vb2_dma_sg_mmap
Date: Mon, 16 Feb 2026 06:42:02 +1000	[thread overview]
Message-ID: <review-overall-20260215-media-vb2-dma-sg-v1-1-91b6aa6c1cec@jannau.net> (raw)
In-Reply-To: <20260215-media-vb2-dma-sg-v1-1-91b6aa6c1cec@jannau.net>

Overall Series Review

Subject: media: videobuf2: Set vma_flags in vb2_dma_sg_mmap
Author: Janne Grunau <j@jannau.net>
Patches: 1
Reviewed: 2026-02-16T06:42:02.240640

---

This is a single-patch series that adds `VM_DONTEXPAND | VM_DONTDUMP` flags to the `vb2_dma_sg_mmap()` function in the videobuf2 DMA scatter/gather allocator. The `vb2_dma_contig` allocator already sets these flags in its mmap handler, and the vmalloc allocator sets `VM_DONTEXPAND`. The missing flags cause a `WARN_ON` in `drm_gem_mmap_obj()` when a DRM driver imports a dma-buf from a V4L2 device that uses `vb2_dma_sg_memops` and the buffer is subsequently mmapped through the DRM GEM path.

The fix is straightforward, correct, and consistent with the existing pattern in the sibling allocators. The commit message is thorough — it explains the problem, provides the call trace, references prior discussion about the broader question of mmap on imported dma-bufs, and includes appropriate Fixes and Cc: stable tags.

No issues found.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-02-15 20:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-15 17:42 [PATCH] media: videobuf2: Set vma_flags in vb2_dma_sg_mmap Janne Grunau
2026-02-15 20:42 ` Claude review: " Claude Code Review Bot
2026-02-15 20:42 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260215-media-vb2-dma-sg-v1-1-91b6aa6c1cec@jannau.net \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox