From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: media: videobuf2: Set vma_flags in vb2_dma_sg_mmap Date: Mon, 16 Feb 2026 06:42:02 +1000 Message-ID: In-Reply-To: <20260215-media-vb2-dma-sg-v1-1-91b6aa6c1cec@jannau.net> References: <20260215-media-vb2-dma-sg-v1-1-91b6aa6c1cec@jannau.net> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: media: videobuf2: Set vma_flags in vb2_dma_sg_mmap Author: Janne Grunau Patches: 1 Reviewed: 2026-02-16T06:42:02.240640 --- This is a single-patch series that adds `VM_DONTEXPAND | VM_DONTDUMP` flags t= o the `vb2_dma_sg_mmap()` function in the videobuf2 DMA scatter/gather alloca= tor. The `vb2_dma_contig` allocator already sets these flags in its mmap hand= ler, and the vmalloc allocator sets `VM_DONTEXPAND`. The missing flags cause = a `WARN_ON` in `drm_gem_mmap_obj()` when a DRM driver imports a dma-buf from = a V4L2 device that uses `vb2_dma_sg_memops` and the buffer is subsequently mm= apped through the DRM GEM path. The fix is straightforward, correct, and consistent with the existing pattern= in the sibling allocators. The commit message is thorough =E2=80=94 it expla= ins the problem, provides the call trace, references prior discussion about t= he broader question of mmap on imported dma-bufs, and includes appropriate Fi= xes and Cc: stable tags. No issues found. --- Generated by Claude Code Patch Reviewer