public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: panel-orientation-quirks: Add various handheld quirks
Date: Tue, 17 Feb 2026 07:19:39 +1000	[thread overview]
Message-ID: <review-overall-20260216204547.293291-1-lkml@antheas.dev> (raw)
In-Reply-To: <20260216204547.293291-1-lkml@antheas.dev>

Overall Series Review

Subject: drm: panel-orientation-quirks: Add various handheld quirks
Author: Antheas Kapenekakis <lkml@antheas.dev>
Patches: 15
Reviewed: 2026-02-17T07:19:39.491903

---

This is a 14-patch series adding panel orientation quirks for various handheld gaming devices and mini laptops to `drm_panel_orientation_quirks.c`. All 14 patches touch only this single file, each adding one or more DMI-based entries to the `orientation_data[]` table. The devices covered include AOKZOE, AYANEO, OneXPlayer, GPD, Zeenix (Tectoy), and Mysten SuiPlay handhelds.

The series is straightforward data-only work. Each patch adds a `dmi_system_id` entry with `DMI_EXACT_MATCH` on vendor and product name, pointing to an existing `drm_dmi_panel_orientation_data` struct. All referenced structs (`lcd800x1280_rightside_up`, `lcd1200x1920_leftside_up`, `lcd1080x1920_rightside_up`, `lcd1080x1920_leftside_up`, `lcd1600x2560_leftside_up`, `lcd1200x1920_rightside_up`, `lcd1600x2560_rightside_up`) are pre-existing and have correct width/height/orientation values. The width/height matching in `drm_get_panel_orientation_quirk()` means quirks only apply when the actual panel resolution matches, which is the correct safeguard for devices like the Ayaneo 3 that ship with two different panel types.

There are two issues worth noting: patch 10 (Zeenix) uses spaces instead of tabs in the entry separator lines, inconsistent with the rest of the file; and patch 14 (X1 Air) has a misleading comment that says "OneXPlayer X1 Intel" while the commit subject and DMI product name both reference "X1Air" / "X1 Air." Neither of these is a correctness bug, but the comment mismatch is worth fixing before merge. Patches 12-14 are missing Reviewed-by tags that the earlier patches have.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-02-16 21:19 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-16 20:45 [PATCH v2 00/14] drm: panel-orientation-quirks: Add various handheld quirks Antheas Kapenekakis
2026-02-16 20:45 ` [PATCH v2 01/14] drm: panel-orientation-quirks: Add AOKZOE A1 Pro Antheas Kapenekakis
2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 02/14] drm: panel-orientation-quirks: Add additional ID for Ayaneo 2021 Antheas Kapenekakis
2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 03/14] drm: panel-orientation-quirks: Add Ayaneo 3 Antheas Kapenekakis
2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 04/14] drm: panel-orientation-quirks: Add OneXPlayer X1 variants Antheas Kapenekakis
2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 05/14] drm: panel-orientation-quirks: Add OneXPlayer X1 Mini variants Antheas Kapenekakis
2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 06/14] drm: panel-orientation-quirks: Add OneXPlayer F1 variants Antheas Kapenekakis
2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 07/14] drm: panel-orientation-quirks: Add OneXPlayer G1 variants Antheas Kapenekakis
2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 08/14] drm: panel-orientation-quirks: Add GPD Win Max (2021) Antheas Kapenekakis
2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 09/14] drm: panel-orientation-quirks: Add GPD Pocket 4 Antheas Kapenekakis
2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 10/14] drm: panel-orientation-quirks: Add Zeenix Lite and Pro Antheas Kapenekakis
2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 11/14] drm: panel-orientation-quirks: add SuiPlay0X1 Antheas Kapenekakis
2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 12/14] drm: panel-orientation-quirks: Add OneXPlayer X1z Antheas Kapenekakis
2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 13/14] drm: panel-orientation-quirks: Add AOKZOE A2 Pro Antheas Kapenekakis
2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
2026-02-16 20:45 ` [PATCH v2 14/14] drm: panel-orientation-quirks: Add OneXPlayer X1 Air Antheas Kapenekakis
2026-02-16 21:19   ` Claude review: " Claude Code Review Bot
2026-02-16 21:19 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260216204547.293291-1-lkml@antheas.dev \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox