From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm: panel-orientation-quirks: Add various handheld quirks Date: Tue, 17 Feb 2026 07:19:39 +1000 Message-ID: In-Reply-To: <20260216204547.293291-1-lkml@antheas.dev> References: <20260216204547.293291-1-lkml@antheas.dev> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm: panel-orientation-quirks: Add various handheld quirks Author: Antheas Kapenekakis Patches: 15 Reviewed: 2026-02-17T07:19:39.491903 --- This is a 14-patch series adding panel orientation quirks for various handheld gaming devices and mini laptops to `drm_panel_orientation_quirks.c`. All 14 patches touch only this single file, each adding one or more DMI-based entries to the `orientation_data[]` table. The devices covered include AOKZOE, AYANEO, OneXPlayer, GPD, Zeenix (Tectoy), and Mysten SuiPlay handhelds. The series is straightforward data-only work. Each patch adds a `dmi_system_id` entry with `DMI_EXACT_MATCH` on vendor and product name, pointing to an existing `drm_dmi_panel_orientation_data` struct. All referenced structs (`lcd800x1280_rightside_up`, `lcd1200x1920_leftside_up`, `lcd1080x1920_rightside_up`, `lcd1080x1920_leftside_up`, `lcd1600x2560_leftside_up`, `lcd1200x1920_rightside_up`, `lcd1600x2560_rightside_up`) are pre-existing and have correct width/height/orientation values. The width/height matching in `drm_get_panel_orientation_quirk()` means quirks only apply when the actual panel resolution matches, which is the correct safeguard for devices like the Ayaneo 3 that ship with two different panel types. There are two issues worth noting: patch 10 (Zeenix) uses spaces instead of tabs in the entry separator lines, inconsistent with the rest of the file; and patch 14 (X1 Air) has a misleading comment that says "OneXPlayer X1 Intel" while the commit subject and DMI product name both reference "X1Air" / "X1 Air." Neither of these is a correctness bug, but the comment mismatch is worth fixing before merge. Patches 12-14 are missing Reviewed-by tags that the earlier patches have. --- Generated by Claude Code Patch Reviewer