From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Pass down hot-plug CONNECTOR ID to user-space
Date: Wed, 18 Feb 2026 06:43:45 +1000 [thread overview]
Message-ID: <review-overall-20260217-hot-plug-passup-v7-0-f8221b2aab51@collabora.com> (raw)
In-Reply-To: <20260217-hot-plug-passup-v7-0-f8221b2aab51@collabora.com>
Overall Series Review
Subject: Pass down hot-plug CONNECTOR ID to user-space
Author: Nicolas Frattaroli <nicolas.frattaroli@collabora.com>
Patches: 3
Reviewed: 2026-02-18T06:43:45.823156
---
This two-patch series adds per-connector hotplug event reporting to the DRM subsystem. Instead of sending a single global hotplug uevent (which forces userspace to re-probe all connectors), it sends individual uevents identifying the specific connector(s) that changed. The motivation is well-described: compositors like Weston can miss rapid on-off-on transitions when they have to guess which connector caused the event.
The approach is straightforward: patch 1 adds a `pending_hp` boolean to `drm_connector` that tracks whether a connector has a status change pending notification, and patch 2 converts the polling and HPD paths to iterate over connectors with `pending_hp` set and send individual events for each.
There is one bug in the series: the `delayed_event` path in `output_poll_execute` sets `changed = true` without any connector having `pending_hp` set, so the new connector-iterating loop will silently drop the hotplug notification. This is a functional regression. There is also a performance concern around `drm_client_dev_hotplug()` being invoked N times instead of once when N connectors change simultaneously.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-02-17 20:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 19:00 [PATCH v7 0/2] Pass down hot-plug CONNECTOR ID to user-space Nicolas Frattaroli
2026-02-17 19:00 ` [PATCH v7 1/2] drm: Introduce pending_hp to drm_connector Nicolas Frattaroli
2026-02-17 20:43 ` Claude review: " Claude Code Review Bot
2026-02-17 19:00 ` [PATCH v7 2/2] drm: Send per-connector hotplug events Nicolas Frattaroli
2026-02-17 20:43 ` Claude review: " Claude Code Review Bot
2026-02-17 20:43 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260217-hot-plug-passup-v7-0-f8221b2aab51@collabora.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox