From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Pass down hot-plug CONNECTOR ID to user-space Date: Wed, 18 Feb 2026 06:43:45 +1000 Message-ID: In-Reply-To: <20260217-hot-plug-passup-v7-0-f8221b2aab51@collabora.com> References: <20260217-hot-plug-passup-v7-0-f8221b2aab51@collabora.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Pass down hot-plug CONNECTOR ID to user-space Author: Nicolas Frattaroli Patches: 3 Reviewed: 2026-02-18T06:43:45.823156 --- This two-patch series adds per-connector hotplug event reporting to the DRM subsystem. Instead of sending a single global hotplug uevent (which forces userspace to re-probe all connectors), it sends individual uevents identifying the specific connector(s) that changed. The motivation is well-described: compositors like Weston can miss rapid on-off-on transitions when they have to guess which connector caused the event. The approach is straightforward: patch 1 adds a `pending_hp` boolean to `drm_connector` that tracks whether a connector has a status change pending notification, and patch 2 converts the polling and HPD paths to iterate over connectors with `pending_hp` set and send individual events for each. There is one bug in the series: the `delayed_event` path in `output_poll_execute` sets `changed = true` without any connector having `pending_hp` set, so the new connector-iterating loop will silently drop the hotplug notification. This is a functional regression. There is also a performance concern around `drm_client_dev_hotplug()` being invoked N times instead of once when N connectors change simultaneously. --- Generated by Claude Code Patch Reviewer