Claude review: gpu: nova-core: miscellaneous improvements

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: gpu: nova-core: miscellaneous improvements
Author: Alexandre Courbot <acourbot@nvidia.com>
Patches: 9
Reviewed: 2026-02-17T15:48:06.496317

---

This is an 8-patch series of miscellaneous cleanups and improvements for nova-core, the Rust-based NVIDIA GPU driver. The patches are authored by Alexandre Courbot and most carry Reviewed-by tags from Lyude Paul and/or Gary Guo. The series is straightforward: it adds a diagnostic warning for unprocessed GSP message data, removes dead code (unused `Display` impls and an unused trait), simplifies sequencer opcode parsing by reading union fields directly, adds `Debug` derives, switches from the kernel's `CStr` alias to the underlying `core::ffi::CStr`, and replaces repeated `pdev.as_ref()` calls with an existing local `dev` reference.

The overall approach is sound. The patches are well-ordered: patch 2 removes `Display` impls before patch 5 adds `Debug` derives (avoiding confusion), and patch 3 simplifies union access before patch 4 removes the now-unnecessary trait. Each patch is independently correct and the series doesn't introduce any regressions.

I found one minor pre-existing formatting issue that the series carries forward, but no bugs or correctness problems in the new code.

---
Generated by Claude Code Patch Reviewer