From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Support for the Pixel 3a XL with the Tianma panel
Date: Tue, 17 Feb 2026 15:51:43 +1000 [thread overview]
Message-ID: <review-overall-20260217000854.131242-1-mailingradian@gmail.com> (raw)
In-Reply-To: <20260217000854.131242-1-mailingradian@gmail.com>
Overall Series Review
Subject: Support for the Pixel 3a XL with the Tianma panel
Author: Richard Acayan <mailingradian@gmail.com>
Patches: 7
Reviewed: 2026-02-17T15:51:43.373818
---
This series adds support for the Google Pixel 3a XL (codename "bonito") with the Tianma/Novatek NT37700F panel variant. It consists of DT bindings additions (patches 1-2), a new panel driver (patch 3), preparatory DTS label additions (patch 4), refactoring of the existing sargo DTS into a common include (patch 5), and the new bonito-tianma DTS (patch 6).
The overall approach is clean and follows established patterns. The DTS refactoring to extract common elements into a shared include is a sensible way to support the closely-related 3a and 3a XL devices. The panel driver is generated from the vendor's DSI command sequences using the well-known `linux-mdss-dsi-panel-driver-generator` tool and follows the modern `mipi_dsi_multi_context` pattern.
There are a few issues to address. The most notable is a comment in patch 6 that says the opposite of what the file actually describes. There is also a value change in patch 5 that changes the Pixel 3a's touchscreen-x-mm from 62 to 63 without explanation. Both should be clarified.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-02-17 5:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-17 0:08 [PATCH v2 0/6] Support for the Pixel 3a XL with the Tianma panel Richard Acayan
2026-02-17 0:08 ` [PATCH v2 1/6] dt-bindings: arm: qcom: document google, bonito-tianma board Richard Acayan
2026-02-17 5:51 ` Claude review: " Claude Code Review Bot
2026-02-17 0:08 ` [PATCH v2 2/6] dt-bindings: panel-simple-dsi: add nt37700f compatible Richard Acayan
2026-02-17 5:51 ` Claude review: " Claude Code Review Bot
2026-02-17 0:08 ` [PATCH v2 3/6] drm/panel: Add Novatek/Tianma NT37700F panel Richard Acayan
2026-02-17 5:51 ` Claude review: " Claude Code Review Bot
2026-02-17 0:08 ` [PATCH v2 4/6] arm64: dts: qcom: sdm670-google-sargo: add touchscreen and display labels Richard Acayan
2026-02-17 5:51 ` Claude review: " Claude Code Review Bot
2026-02-17 0:08 ` [PATCH v2 5/6] arm64: dts: qcom: sdm670-google: add common device tree include Richard Acayan
2026-02-17 5:51 ` Claude review: " Claude Code Review Bot
2026-02-17 0:08 ` [PATCH v2 6/6] arm64: dts: qcom: add support for pixel 3a xl with the tianma panel Richard Acayan
2026-02-17 5:51 ` Claude review: " Claude Code Review Bot
2026-02-17 5:51 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-10 0:26 [PATCH v3 0/5] Support for the Pixel 3a XL with the Tianma panel Richard Acayan
2026-03-10 1:42 ` Claude review: " Claude Code Review Bot
2026-02-10 2:32 [PATCH 0/6] " Richard Acayan
2026-02-11 6:47 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260217000854.131242-1-mailingradian@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox