From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Avoid oops on illegal VGA register access Date: Wed, 18 Feb 2026 06:51:00 +1000 Message-ID: In-Reply-To: <20260217165214.236482-1-Simon.Richter@hogyros.de> References: <20260217165214.236482-1-Simon.Richter@hogyros.de> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Overall Series Review Subject: Avoid oops on illegal VGA register access Author: Simon Richter Patches: 2 Reviewed: 2026-02-18T06:51:00.223518 --- This is a single-patch series that adds error handling for `vga_get_uninter= ruptible()` in the i915 VGA code. The stated motivation is to avoid oops on= non-x86 platforms where VGA registers cannot be mapped, which would cause = `vga_get()` to return `-ENODEV`. The patch modifies `intel_vga_get()` to pr= opagate error codes, and `intel_vga_disable()` to handle them by skipping V= GA register access and jumping to the MMIO-based VGA plane disable. The patch is based on a tree that contains a refactoring of `intel_vga.c` (= adding `intel_vga_get()`, `intel_vga_put()`, `intel_pci_set_io_decode()`, e= tc.) that has not yet landed in drm-next. The base commit `15658979e64a` is= not present in drm-next. This means the patch cannot be applied on its own= =E2=80=94 it depends on a prerequisite refactoring series. The cover lette= r acknowledges this indirectly, mentioning that "complementary changes in v= gaarb" are also needed, but the dependency on the i915 VGA refactoring seri= es is not stated. There are a few coding style issues and one incomplete aspect: the error ha= ndling is only added for `intel_vga_get()` within `intel_vga_disable()`, bu= t if the underlying problem is that `vga_get_uninterruptible()` can fail on= non-x86, this should also be considered for `intel_vga_reset_io_mem()` whi= ch similarly calls `vga_get_uninterruptible()` without checking the return = value. --- Generated by Claude Code Patch Reviewer