Claude review: accel: ethosu: Runtime PM refcounting and cmd stream validation fixes

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: accel: ethosu: Runtime PM refcounting and cmd stream validation fixes
Author: "Rob Herring (Arm)" <robh@kernel.org>
Patches: 4
Reviewed: 2026-02-19T09:57:30.759643

---

This is a three-patch fix series for the Arm Ethos-U NPU accelerator driver, addressing runtime PM refcount underflow on job submit failure, incorrect scalar mode detection for elementwise operations on the u65, and potential integer underflow in IFM size calculations. The patches are from Rob Herring and fix real bugs found during testing with additional models.

The architectural approach in patch 1 — splitting cleanup into pre-queue and post-queue paths — is the right idea. The two hardware-specific fixes in patches 2 and 3 are straightforward and well-motivated. One concern in patch 1 is that `done_fence` (which is separately kzalloc'd) is not freed by `ethosu_job_err_cleanup`, resulting in a memory leak on the error paths that go through `out_cleanup_job` or `out_put_job`. This was also leaked in the original code (since `dma_fence_put` on a zero-initialized fence triggers a kref WARN and doesn't actually free), but it would be good to fix it properly while restructuring the cleanup code.

---
Generated by Claude Code Patch Reviewer