From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: drm/kmb: Fix error pointer dereference Date: Mon, 23 Feb 2026 06:12:42 +1000 Message-ID: In-Reply-To: <20260219224426.1122073-1-ethantidmore06@gmail.com> References: <20260219224426.1122073-1-ethantidmore06@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: drm/kmb: Fix error pointer dereference Author: Ethan Tidmore Patches: 1 Reviewed: 2026-02-23T06:12:42.068591 --- This is a single-patch fix for a real error-pointer dereference bug in the KMB (KeemBay) DRM driver's probe function. When `kmb_dsi_init()` returns an error pointer, the error cleanup path at `err_free1` passes that error pointer directly to `kmb_dsi_host_unregister()`, which immediately dereferences it in `kmb_dsi_clk_disable()`, causing a crash. The fix is correct and the commit message clearly explains the problem and the solution. The only question is whether the approach is the most idiomatic one for kernel error unwinding -- more on that below. --- Generated by Claude Code Patch Reviewer