From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/exynos: vidi: fix various memory corruption bugs
Date: Mon, 23 Feb 2026 06:11:02 +1000 [thread overview]
Message-ID: <review-overall-20260220033550.124346-1-aha310510@gmail.com> (raw)
In-Reply-To: <20260220033550.124346-1-aha310510@gmail.com>
Overall Series Review
Subject: drm/exynos: vidi: fix various memory corruption bugs
Author: Jeongjun Park <aha310510@gmail.com>
Patches: 3
Reviewed: 2026-02-23T06:11:02.494577
---
This is a two-patch backport series for the 6.18.y and 6.19.y stable trees, fixing two bugs in the Exynos DRM VIDI (Virtual Display Interface) driver. Both patches have upstream commits (d3968a0d85b2 and d4c98c077c7f respectively), already merged to drm-next.
Patch 1 fixes a context lookup bug in `vidi_connection_ioctl()` where the driver was incorrectly fetching `vidi_context` from the master DRM device's `driver_data` instead of from the vidi component device. Patch 2 fixes a direct user pointer dereference where `vidi->edid` (a user-space pointer passed via ioctl) was cast and accessed directly in kernel space without `copy_from_user()`.
Both fixes are correct and match the code already present in drm-next. The series is properly ordered: patch 1 introduces the `vidi_dev` infrastructure needed for the correct device lookup, and patch 2 builds on that to also fix the unsafe user pointer access. No significant issues found.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-02-22 20:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 3:35 [PATCH 6.19.y 6.18.y 0/2] drm/exynos: vidi: fix various memory corruption bugs Jeongjun Park
2026-02-20 3:35 ` [PATCH 6.19.y 6.18.y 1/2] drm/exynos: vidi: use priv->vidi_dev for ctx lookup in vidi_connection_ioctl() Jeongjun Park
2026-02-22 20:11 ` Claude review: " Claude Code Review Bot
2026-02-20 3:35 ` [PATCH 6.19.y 6.18.y 2/2] drm/exynos: vidi: fix to avoid directly dereferencing user pointer Jeongjun Park
2026-02-22 20:11 ` Claude review: " Claude Code Review Bot
2026-02-22 20:11 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260220033550.124346-1-aha310510@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox