From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: accel/ivpu: Update FW Boot API to version 3.29.4 Date: Sat, 21 Feb 2026 05:55:39 +1000 Message-ID: In-Reply-To: <20260220160116.220367-1-maciej.falkowski@linux.intel.com> References: <20260220160116.220367-1-maciej.falkowski@linux.intel.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: accel/ivpu: Update FW Boot API to version 3.29.4 Author: Maciej Falkowski Patches: 1 Reviewed: 2026-02-21T05:55:39.101746 --- This is a single-patch series that updates the Intel VPU (NPU) firmware boot API header from version 3.28.3 to 3.29.4. The patch removes unused boot parameter fields (PLL configuration, IRQ redirects, warm boot data, memory allocator addresses, and temperature sensor period), replacing them with appropriately-sized reserved arrays to preserve the binary layout. The `vpu_warm_boot_section` struct is also removed. Additionally, all C-style `/*` comments are converted to doxygen-style `/**` comments, and doxygen file-level markup is added. The structural changes are size-correct: each removed field or group of fields is replaced by a reserved array of the same total size, preserving ABI compatibility. All removed fields and macros (`VPU_BOOT_PLL_COUNT`, `VPU_BOOT_PLL_OUT_COUNT`, etc.) are confirmed unused in the driver code. The patch is straightforward and low-risk. There is one minor inconsistency worth noting between the commit message description and the version bump, and a couple of small comment-style nits, but no correctness issues. --- Generated by Claude Code Patch Reviewer