From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: 6.12 and below: amdgpu: fix panic with SI and DC Date: Mon, 23 Feb 2026 06:01:56 +1000 Message-ID: In-Reply-To: <20260221034402.69537-1-rosenp@gmail.com> References: <20260221034402.69537-1-rosenp@gmail.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: 6.12 and below: amdgpu: fix panic with SI and DC Author: Rosen Penev Patches: 12 Reviewed: 2026-02-23T06:01:56.568456 --- This is a 2-patch stable-only series requesting reverts of two commits in `si_dpm.c` that added high-pixelclock workarounds for Southern Islands GPUs. The author reports that these commits cause kernel panics on AMD 7750 when booting with `amdgpu.dc=1` on stable kernels older than 6.18. The root cause appears to be that the added code accesses `adev->mode_info.crtcs[i]->connector` via `to_amdgpu_connector()`, which is presumably invalid or NULL under the DC codepath on these older kernels. In 6.17+, further commits reworked this code to use `display_cfg` instead, fixing the issue, but those changes are too involved to backport cleanly. The code changes themselves are mechanically correct -- they are clean `git revert` outputs that leave the code in a compilable and functional state. The main issues are with the commit messages, which Greg KH has already flagged on the list. Patch 1 has no explanation at all for why the revert is needed, and patch 2 has typos and doesn't specify which stable branches are affected. The submitter has acknowledged a v2 is needed. One observation worth noting: patch 1 alone does not fix the crash. The offending connector access remains until patch 2 removes it. Between patches 1 and 2, the kernel is still broken when using DC on SI. While this is acceptable for a revert series (individual patches don't need to be independently useful if they're always applied together), it's worth mentioning since this is going into stable. --- Generated by Claude Code Patch Reviewer