public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: Implement Send and Sync for clk
Date: Tue, 24 Feb 2026 10:11:35 +1000	[thread overview]
Message-ID: <review-overall-20260223-clk-send-sync-v5-0-181bf2f35652@google.com> (raw)
In-Reply-To: <20260223-clk-send-sync-v5-0-181bf2f35652@google.com>

Overall Series Review

Subject: Implement Send and Sync for clk
Author: Alice Ryhl <aliceryhl@google.com>
Patches: 4
Reviewed: 2026-02-24T10:11:35.760888

---

This is a small, well-structured 3-patch series from Alice Ryhl that adds `Send` and `Sync` trait implementations to the Rust `Clk` type in the kernel clock subsystem, then removes the corresponding workaround `unsafe impl` blocks in two drivers that had been manually marking their data structures as `Send`/`Sync` to compensate for the missing impls on `Clk`.

The series is correctly ordered: patch 1 adds the trait implementations to the core type, and patches 2-3 remove the now-redundant workarounds in the tyr DRM driver and the th1520 PWM driver. Each patch compiles correctly on its own -- patches 2 and 3 depend on patch 1, but never introduce a window where correctness is broken. The series has multiple Reviewed-by and Acked-by tags from relevant maintainers and Rust-for-Linux developers.

No significant issues were found. The safety justifications are reasonable: the C clock framework uses internal locking for its operations (prepare/enable/disable/unprepare/get_rate/set_rate are all internally synchronized), and `clk_put` does not need to be called from the same thread as `clk_get`. The removal of the driver-side workarounds is clean -- the auto-trait derivation works correctly because all constituent fields of both `TyrData` and `Th1520PwmDriverData` are now `Send` + `Sync`.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-02-24  0:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-23 10:08 [PATCH v5 0/3] Implement Send and Sync for clk Alice Ryhl
2026-02-23 10:08 ` [PATCH v5 1/3] rust: clk: implement Send and Sync Alice Ryhl
2026-02-24  0:11   ` Claude review: " Claude Code Review Bot
2026-02-23 10:08 ` [PATCH v5 2/3] tyr: remove impl Send/Sync for TyrData Alice Ryhl
2026-02-24  0:11   ` Claude review: " Claude Code Review Bot
2026-02-23 10:08 ` [PATCH v5 3/3] pwm: th1520: remove impl Send/Sync for Th1520PwmDriverData Alice Ryhl
2026-02-24  0:11   ` Claude review: " Claude Code Review Bot
2026-02-24  0:11 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260223-clk-send-sync-v5-0-181bf2f35652@google.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox