From mboxrd@z Thu Jan 1 00:00:00 1970 From: Claude Code Review Bot To: dri-devel-reviews@example.com Subject: Claude review: Implement Send and Sync for clk Date: Tue, 24 Feb 2026 10:11:35 +1000 Message-ID: In-Reply-To: <20260223-clk-send-sync-v5-0-181bf2f35652@google.com> References: <20260223-clk-send-sync-v5-0-181bf2f35652@google.com> X-Mailer: Claude Code Patch Reviewer Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Overall Series Review Subject: Implement Send and Sync for clk Author: Alice Ryhl Patches: 4 Reviewed: 2026-02-24T10:11:35.760888 --- This is a small, well-structured 3-patch series from Alice Ryhl that adds `Send` and `Sync` trait implementations to the Rust `Clk` type in the kernel clock subsystem, then removes the corresponding workaround `unsafe impl` blocks in two drivers that had been manually marking their data structures as `Send`/`Sync` to compensate for the missing impls on `Clk`. The series is correctly ordered: patch 1 adds the trait implementations to the core type, and patches 2-3 remove the now-redundant workarounds in the tyr DRM driver and the th1520 PWM driver. Each patch compiles correctly on its own -- patches 2 and 3 depend on patch 1, but never introduce a window where correctness is broken. The series has multiple Reviewed-by and Acked-by tags from relevant maintainers and Rust-for-Linux developers. No significant issues were found. The safety justifications are reasonable: the C clock framework uses internal locking for its operations (prepare/enable/disable/unprepare/get_rate/set_rate are all internally synchronized), and `clk_put` does not need to be called from the same thread as `clk_get`. The removal of the driver-side workarounds is clean -- the auto-trait derivation works correctly because all constituent fields of both `TyrData` and `Th1520PwmDriverData` are now `Send` + `Sync`. --- Generated by Claude Code Patch Reviewer